fix: removed openzeppelin dependency, fixed dev dependencies, and upd… #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated the contributing markdown to be clearer
kiriyaga-txfusion
approved these changes
Jun 3, 2024
This was referenced Jun 11, 2024
This was referenced Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated the contributing markdown to be clearer
What 💻
Currently, attempting to add this to a repo that uses a newer version of openzeppelin contracts will cause this to error out. So we removed that as it was never actually used in the verification package. Additionally, running tests was unclear (and to be fair, is still a bit unclear) and some dev dependencies were missing in order to run the tests. They have been added in the
package.json.