Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement plugin settings in admin console #108

Open
mickmister opened this issue May 4, 2023 · 11 comments · May be fixed by #126
Open

Implement plugin settings in admin console #108

mickmister opened this issue May 4, 2023 · 11 comments · May be fixed by #126
Labels
Type/Enhancement New feature or improvement of existing feature
Milestone

Comments

@mickmister
Copy link
Contributor

The configuration for the plugin is currently handled directly in the server's config.json, which makes it difficult to manage since you can't use the MM UI to do so.

The task here is to declare these config settings in the plugin's plugin.json file, and implement any complex settings as a custom setting in the admin console.

@Kshitij-Katiyar
Copy link
Contributor

Kshitij-Katiyar commented May 8, 2023

@mickmister I have a clarification about this.
If this ticket is urgent just for the sake of this plugin working with the cloud servers. We can create a long text field, put that json into that field in the plugin configuration, and parse that from there. This would be a quick solution to make this work with cloud servers.
The second solution would be to create proper custom components in the web app to get all these settings from the plugin configurations. This would take longer as we are creating customs components and this would not work in mobile apps as well.

@mickmister
Copy link
Contributor Author

@Kshitij-Katiyar This ticket is not urgent but is high impact, as mentioned here https://community.mattermost.com/core/pl/r385h5s83fbrjjk6yk3sc3aeqy

We can create a long text field, put that json into that field in the plugin configuration, and parse that from there. This would be a quick solution to make this work with cloud servers.

This has been a long time coming with this not being easy to configure. I would prefer if we use custom components instead, to make it easy to configure for on-prem admins as well.

This would take longer as we are creating customs components and this would not work in mobile apps as well.

This can't be configured on the mobile app today, and the goal of this ticket is not to support the mobile app. The settings are already living in the PluginSettings part of the server's config, so the admin console is the place to have this. This page is not accessible by the mobile, and that's fine for the purpose of this plugin/ticket.

@mickmister
Copy link
Contributor Author

@Kshitij-Katiyar Note that there is progress on this, using the simpler approach you mentioned #92. However, I'm still thinking we should implement as custom components.

@Kshitij-Katiyar
Copy link
Contributor

@mickmister I have made some components and also registered the same in the system console settings. Can you please take a look and give your suggestions for the same.

Screenshot from 2023-07-14 17-09-17
Screenshot from 2023-07-14 17-09-26

@mickmister
Copy link
Contributor Author

@DHaussermann What are your thoughts on how this configuration UI looks?

@mickmister
Copy link
Contributor Author

@Kshitij-Katiyar How does it look when writing the markdown message?

@mickmister
Copy link
Contributor Author

@raghavaggarwal2308 Is this PR still being worked on? Brightscout#15

@mickmister
Copy link
Contributor Author

Asking so we can determine whether to move forward with that PR or #92

@raghavaggarwal2308
Copy link

@mickmister Yes, we are working on Brightscout#15. We will create a PR in mattermost org ASAP.

@Kshitij-Katiyar
Copy link
Contributor

Asking so we can determine whether to move forward with that PR or #92

@mickmister This is taking longer than expected, we can move with the other PR #92 in the meantime if you want.

@mickmister
Copy link
Contributor Author

@Kshitij-Katiyar Sounds good to me. I'm thinking the changes will be backwards compatible for both PRs. Are you able to drive the other PR forward? Thanks for pointing this out @Kshitij-Katiyar

@Kshitij-Katiyar Kshitij-Katiyar added this to the v1.4.0 milestone Apr 12, 2024
@Kshitij-Katiyar Kshitij-Katiyar added the Type/Enhancement New feature or improvement of existing feature label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Enhancement New feature or improvement of existing feature
Projects
None yet
3 participants