-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement plugin settings in admin console #108
Comments
@mickmister I have a clarification about this. |
@Kshitij-Katiyar This ticket is not urgent but is high impact, as mentioned here https://community.mattermost.com/core/pl/r385h5s83fbrjjk6yk3sc3aeqy
This has been a long time coming with this not being easy to configure. I would prefer if we use custom components instead, to make it easy to configure for on-prem admins as well.
This can't be configured on the mobile app today, and the goal of this ticket is not to support the mobile app. The settings are already living in the |
@Kshitij-Katiyar Note that there is progress on this, using the simpler approach you mentioned #92. However, I'm still thinking we should implement as custom components. |
@mickmister I have made some components and also registered the same in the system console settings. Can you please take a look and give your suggestions for the same. |
@DHaussermann What are your thoughts on how this configuration UI looks? |
@Kshitij-Katiyar How does it look when writing the markdown message? |
@raghavaggarwal2308 Is this PR still being worked on? Brightscout#15 |
Asking so we can determine whether to move forward with that PR or #92 |
@mickmister Yes, we are working on Brightscout#15. We will create a PR in mattermost org ASAP. |
@mickmister This is taking longer than expected, we can move with the other PR #92 in the meantime if you want. |
@Kshitij-Katiyar Sounds good to me. I'm thinking the changes will be backwards compatible for both PRs. Are you able to drive the other PR forward? Thanks for pointing this out @Kshitij-Katiyar |
The configuration for the plugin is currently handled directly in the server's
config.json
, which makes it difficult to manage since you can't use the MM UI to do so.The task here is to declare these config settings in the plugin's
plugin.json
file, and implement any complex settings as a custom setting in the admin console.The text was updated successfully, but these errors were encountered: