Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM-47046 Use version of React DOM provided by web app #317

Closed
catalintomai opened this issue Sep 18, 2022 · 1 comment
Closed

MM-47046 Use version of React DOM provided by web app #317

catalintomai opened this issue Sep 18, 2022 · 1 comment
Assignees
Labels
4: Reviews Complete All reviewers have approved the pull request

Comments

@catalintomai
Copy link

From here:

"For some more context, see here. The short version though is that we updated the web app to React 17, and there's a chance that plugins will have some issues with it because they're compiled with the React 16 version of ReactDOM. I'm submitting PRs to the 3 products, the demo plugin, and the plugin template to have them use the web app's version of React DOM to fix any immediate issues, but we'll want to properly migrate them to React 17 going forward."

Ticket Link
https://mattermost.atlassian.net/browse/MM-47046

Related Pull Requests
mattermost/mattermost-plugin-playbooks#1489
mattermost-community/focalboard#3861
mattermost-community/mattermost-plugin-todo#190
mattermost/mattermost-plugin-starter-template#169

@mickmister
Copy link
Contributor

Solved with #318

@hanzei hanzei removed the Triage label Oct 4, 2022
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

No branches or pull requests

3 participants