Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin crashes from time to time on getIssue FieldValue method on issues with no priority set #820

Closed
DummyThatMatters opened this issue Nov 16, 2021 · 0 comments · Fixed by #821
Labels
Help Wanted Community help wanted Type/Bug Something isn't working

Comments

@DummyThatMatters
Copy link
Contributor

DummyThatMatters commented Nov 16, 2021

I cant name exact steps to reproduce the issue, but we have plugin failures from time to time with following error in the logs:

"msg":"Plugin failed to ServeHTTP, RPC call failed","plugin_id":"jira","error":"connection is shut down"}
"msg":"Plugin failed to ServeHTTP, muxBroker couldn't accept connection","plugin_id":"jira","serve_http_stream_id":2922,"error":"timeout waiting for accept"}
"msg":"Health check failed for plugin","id":"jira","error":"Plugin RPC connection is not responding"}
"msg":"error closing client during Kill","plugin_id":"jira","wrapped_extras":"errconnection is shut down"}
"msg":"RPC call OnDeactivate to plugin failed.","plugin_id":"jira","error":"connection is shut down"}
"msg":"plugin failed to exit gracefully","plugin_id":"jira"}
"msg":"Access to route for non-existent plugin"

On log level turned to debug we observed following error message over and over again:

[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0xb2905e]
panic: runtime error: invalid memory address or nil pointer dereference
/mnt/d/Documents/MyProj/Jobs/RTK/Sources/plug-ins/mattermost-plugin-jira/server/issue.go:867 +0x1be
goroutine 67 [running]:
main.getIssueFieldValue(0xc0004c5410, 0xc0003fa1a0, 0x8, 0x1)
.../mattermost-plugin-jira/server/subscribe.go:162 +0x292
.../mattermost-plugin-jira/server/subscribe.go:187 +0x238
main.(*Plugin).getChannelsSubscribed(0xc0002f4600, 0xc0000c4960, 0xc0005f2000, 0x13, 0x0, 0x0, 0x0, 0xc8, 0x0)
main.(*Plugin).matchesSubsciptionFilters(0xc0002f4600, 0xc0000c4960, 0xc0008fd320, 0xc0008fd350, 0xc0008fd380, 0xc0005f4460, 0x1, 0x4, 0x0)
main.webhookWorker.work(0x6, 0xc0002f4600, 0xc00010f800)
.../mattermost-plugin-jira/server/webhook_worker.go:69 +0x2a5
main.webhookWorker.process(0x6, 0xc0002f4600, 0xc00010f800, 0xc000303590, 0x0, 0x0)
Plugin failed to ServeHTTP, RPC call failed","plugin_id":"jira","error":"connection is shut down

It seems that error appears when someone do some operation with ticket that have no priority field set.

@DummyThatMatters DummyThatMatters changed the title Plugin cruches from time to time on getIssueFieldValue method on issues with no priority set Plugin crushes from time to time on getIssueFieldValue method on issues with no priority set Nov 16, 2021
@DummyThatMatters DummyThatMatters changed the title Plugin crushes from time to time on getIssueFieldValue method on issues with no priority set Plugin crashes from time to time on getIssue FieldValue method on issues with no priority set Nov 16, 2021
@hanzei hanzei added Help Wanted Community help wanted Type/Bug Something isn't working labels Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Community help wanted Type/Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants