Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Check has not yet been added to master branch #843

Closed
DHaussermann opened this issue Feb 28, 2022 · 3 comments · Fixed by #844
Closed

Version Check has not yet been added to master branch #843

DHaussermann opened this issue Feb 28, 2022 · 3 comments · Fixed by #844
Assignees
Labels
Type/Bug Something isn't working
Milestone

Comments

@DHaussermann
Copy link

We don't have a version bump PR for Jira yet, but I have done some testing from the master brach for the release. That said, I noticed that no PR was ever up to bump the minimum server version to v6.5.0

This should be in place to prevent the plugin from running on older server version as per previous discussions.
image

@DHaussermann DHaussermann added Triage Type/Bug Something isn't working labels Feb 28, 2022
@DHaussermann
Copy link
Author

Maybe @levb can confirm my understanding of the expected behavior here.

@levb
Copy link
Contributor

levb commented Feb 28, 2022

AFAIU, we do not require any new APIs from the server, merely exposing new hooks, therefore increasing the server version was not strictly necessary. I'll leave it to @hanzei to decide if we should update as a matter of policy.

@hanzei hanzei self-assigned this Feb 28, 2022
@hanzei hanzei removed the Triage label Feb 28, 2022
@hanzei hanzei added this to the v3.2.0 milestone Feb 28, 2022
@hanzei
Copy link
Collaborator

hanzei commented Feb 28, 2022

Yes, we should update the minimum server version to follow the policy we set our self.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants