Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jira bot DMs you if you mention yourself in a comment on a Jira issue #857

Closed
mickmister opened this issue May 11, 2022 · 2 comments · Fixed by #973
Closed

Jira bot DMs you if you mention yourself in a comment on a Jira issue #857

mickmister opened this issue May 11, 2022 · 2 comments · Fixed by #973
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Milestone

Comments

@mickmister
Copy link
Contributor

mickmister commented May 11, 2022

No description provided.

@mickmister mickmister added Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers labels May 11, 2022
@Kshitij-Katiyar
Copy link
Contributor

Kshitij-Katiyar commented Sep 5, 2023

@mickmister The issue you mentioned is not reproducible on my Mattermost server version 8.0.1.
Also, this case is already handled in the code, please check the below link for the same
https://github.com/mattermost/mattermost-plugin-jira/blob/97184a537109367fa455bbe6700f59f0950211d0/server/webhook_parser.go#L273C4-L273C4

@mickmister
Copy link
Contributor Author

mickmister commented Sep 5, 2023

Also, this case is already handled in the code, please check the below link for the same

That code was added 4 years ago, so I would expect that to be applied to the version I reported this on, in May 2022. Maybe there's a bug where that if statement is not correct.

if u == jwh.User.Name || u == jwh.User.AccountID {
continue
}

The issue you mentioned is not reproducible on my Mattermost server version 8.0.1.

The plugin version and Jira instance type / version is really what matters here. Things change on Jira's side from time to time, including how users are referenced in comments. In the case of me reporting this, I'm thinking I experienced this on Jira Cloud in production with plugin version 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Help Wanted Community help wanted Type/Bug Something isn't working Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
4 participants