PLT-6214 Move channel store and actions over to redux #6235

jwilander · 2017-04-25T21:08:06Z

Summary

Move channel store and actions over to redux. Waiting on #6222 but ready for PM review.

Testing areas:

Creating/deleting/joining/leaving channels
Channel user management (roles, removing, adding, etc.)
Unreads between channels
Updating channel notification settings
Updating channel (header, purpose, etc.)
Auto-linking channels
Searching in a channel
Anything else channel related you can think of

Ticket Link

https://mattermost.atlassian.net/browse/PLT-6214

jasonblais · 2017-04-26T12:51:32Z

@jwilander the build seems to fail

jwilander · 2017-04-26T12:53:03Z

Yeah, I'm looking into it. Seems unrelated to my changes

EDIT: I broke a unit test -.- (fixed now)

jasonblais · 2017-04-26T15:48:27Z

Tested on Win10/Chrome.

i'll have time later today to test channel notification preferences for email/mobile, gotta hop into something else for a bit,

Creating/deleting/joining/leaving channels
Unreads (messages and mentions) across channels
Updating channel (header, purpose, etc.)
Auto-linking channels
Searching in a channel
Pinning posts, favoriting channels
Max notifications settings
Channel member count icon
Channel user management (promoting/demoting from channel admin, removing, adding, etc.)
Notification preferences for 'mark channels as unread' and 'desktop notifications'

Joining a channel post an incorrect system message:

Observed: {username} added to the channel by {username}

Expected: {username} has joined the channel.

Deleted channel appears bolded in the sidebar for other users

create a private channel
add other users to the channel
delete the channel

observed: (for other users) Channel remains bolded in the sidebar. System message jason has archived the channel. is posted

expected: (for other users) Channel disappears from the sidebar

Leaving a channel posts an incorrect system message

observed: test was removed from the channel
expected: test has left the channel.

Private channels appear in "more public channel" list giving a permission error when trying to join

Resetting channel URL doesn't close the "rename channel" modal properly

create a channel
go to "Rename Channel" option
change the URL
hit "Save"
observed: no visible action; unable to close the modal without refresh (the URL does successfully change though)

Creating a DM fails and redirects you to Town Square

Click "More..." below DM list
Choose one member
Click "Go"
observed: User redirected to Town Square

Changing "Mark Channel Unread" only to mentions also changes "Send desktop notifications" to "Never" in the UI (although the desktop notification setting itself doesn't change)

EDIT: It seems the "Mark Channel Unread" option in the UI keeps changing based on "send desktop notification" setting, although the functionality doesn't actually change

jasonblais · 2017-04-26T15:49:40Z

Also found a bug that repros on master: https://mattermost.atlassian.net/browse/PLT-6414

jwilander · 2017-04-26T15:56:12Z

Thanks @jasonblais! I'll go through these and fix them a bit later

jwilander · 2017-04-27T13:10:02Z

@jasonblais fixed all above issues except for 7 which I wasn't able to reproduce

jasonblais · 2017-04-27T21:27:58Z

Confirm 1 - 6 are fixed.

Got better repro steps for 7

Set Channel Notification Preferences > Mark Channel Unread to Only for mentions
Save
Close the modal
reopen channel notification preferences

Observed: Send desktop notifications set to Never in the UI (although it's actually set to whatever it was before)

Testing email/mobile push notifications right now,

jasonblais · 2017-04-27T21:41:50Z

8 - Setting one channel notification preference resets the other

set Send Desktop Notifications to 'only for mentions' (observed: notifications received for mentions only)
set Mark Channel Unread to 'only for mentions'
observed: Desktop notifications received for all messages. (The UI says never due to the bug described in 7)

Similarly, setting Send Desktop Notifications back to 'only for mentions' resets the Mark Channel Unread option. Clicking to edit the setting doesn't show either option being selected.

9 - Channel mobile push notification preferences don't work. They won't overwrite the account preferences.

have mobile push notification set 'for all activity' in Account Settings
change channel notification preferences to 'never'

Observed: Mobile push notifications for that channel keep coming. Same with different combinations of account/channel notification preferences.

(PS: No issues with email notifications at the account-level - I realized we don't have channel-specific settings for them)

jwilander · 2017-04-27T22:39:37Z

Alright fixed 7,8,9. Thanks for the extra repro steps, that helped a lot

jasonblais

confirmed fixes

enahum · 2017-04-28T13:38:47Z

webapp/actions/channel_actions.jsx

+    patchChannel,
+    getChannelMembersByIds,
+    deleteChannel as deleteChannelRedux
+} from 'mattermost-redux/actions/channels';


Why not do something like import * as ChannelActions from 'mattermost-redux/actions/channels'? im really 0/5 but it seems simpler that way

enahum · 2017-04-28T13:41:34Z

webapp/actions/channel_actions.jsx

@@ -283,11 +239,11 @@ export function unmarkFavorite(channelId) {
 }

 export function loadChannelsForCurrentUser() {
-    AsyncClient.getChannels().then(() => {
-        AsyncClient.getMyChannelMembers().then(() => {
+    fetchMyChannelsAndMembers(TeamStore.getCurrentId())(dispatch, getState).then(


im also 0/5 on this but you could do

fetchMyChannelsAndMembers(TeamStore.getCurrentId())(dispatch, getState). then(loadDMsAndGMsForUnreads);

crspeller · 2017-04-28T14:04:42Z

config/config.json

@@ -70,7 +70,7 @@
    },
    "SqlSettings": {
        "DriverName": "mysql",
-        "DataSource": "mmuser:mostest@tcp(dockerhost:3306)/mattermost_test?charset=utf8mb4,utf8&readTimeout=30s&writeTimeout=30s",


Unintended change.

jwilander · 2017-04-28T14:25:33Z

@crspeller fixed

jwilander added 1: PM Review Requires review by a product manager Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Setup Old Test Server Triggers the creation of a test server labels Apr 25, 2017

jwilander added this to the v3.9.0 milestone Apr 25, 2017

jasonblais self-assigned this Apr 26, 2017

jwilander added 4 commits April 27, 2017 09:05

Move channel store and actions over to redux

4baebca

Fix style errors

82d046b

Fix unit test

b361764

Various fixes

b7b705b

jwilander force-pushed the redux-part3 branch from e57f6d4 to b7b705b Compare April 27, 2017 13:06

jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) Setup Old Test Server Triggers the creation of a test server labels Apr 27, 2017

jasonblais added Awaiting Submitter Action Blocked on the author and removed Awaiting Submitter Action Blocked on the author labels Apr 27, 2017

More fixes

a5dffda

jasonblais added Setup Old Test Server Triggers the creation of a test server and removed Setup Old Test Server Triggers the creation of a test server labels Apr 27, 2017

jasonblais approved these changes Apr 28, 2017

View reviewed changes

jasonblais added 2: Dev Review Requires review by a developer and removed 1: PM Review Requires review by a product manager labels Apr 28, 2017

jasonblais removed the Setup Old Test Server Triggers the creation of a test server label Apr 28, 2017

enahum reviewed Apr 28, 2017

View reviewed changes

enahum approved these changes Apr 28, 2017

View reviewed changes

crspeller requested changes Apr 28, 2017

View reviewed changes

jwilander unassigned jasonblais Apr 28, 2017

Revert config changes

12cb9b8

crspeller approved these changes Apr 28, 2017

View reviewed changes

crspeller merged commit 9690648 into master Apr 28, 2017

crspeller deleted the redux-part3 branch April 28, 2017 17:16

jasonblais added Changelog/Not Needed Does not require a changelog entry Docs/Not Needed Does not require documentation Tests/Not Needed New release tests not required labels Apr 29, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLT-6214 Move channel store and actions over to redux #6235

PLT-6214 Move channel store and actions over to redux #6235

jwilander commented Apr 25, 2017

jasonblais commented Apr 26, 2017

jwilander commented Apr 26, 2017 •

edited

Loading

jasonblais commented Apr 26, 2017 •

edited

Loading

jasonblais commented Apr 26, 2017

jwilander commented Apr 26, 2017

jwilander commented Apr 27, 2017

jasonblais commented Apr 27, 2017

jasonblais commented Apr 27, 2017 •

edited

Loading

jwilander commented Apr 27, 2017

jasonblais left a comment

enahum Apr 28, 2017

enahum Apr 28, 2017

crspeller Apr 28, 2017

jwilander commented Apr 28, 2017

PLT-6214 Move channel store and actions over to redux #6235

PLT-6214 Move channel store and actions over to redux #6235

Conversation

jwilander commented Apr 25, 2017

Summary

Ticket Link

jasonblais commented Apr 26, 2017

jwilander commented Apr 26, 2017 • edited Loading

jasonblais commented Apr 26, 2017 • edited Loading

jasonblais commented Apr 26, 2017

jwilander commented Apr 26, 2017

jwilander commented Apr 27, 2017

jasonblais commented Apr 27, 2017

jasonblais commented Apr 27, 2017 • edited Loading

jwilander commented Apr 27, 2017

jasonblais left a comment

Choose a reason for hiding this comment

enahum Apr 28, 2017

Choose a reason for hiding this comment

enahum Apr 28, 2017

Choose a reason for hiding this comment

crspeller Apr 28, 2017

Choose a reason for hiding this comment

jwilander commented Apr 28, 2017

jwilander commented Apr 26, 2017 •

edited

Loading

jasonblais commented Apr 26, 2017 •

edited

Loading

jasonblais commented Apr 27, 2017 •

edited

Loading