Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser: automatically close the browser if the tests pass #4

Open
jonathanong opened this issue Dec 11, 2013 · 3 comments
Open

browser: automatically close the browser if the tests pass #4

jonathanong opened this issue Dec 11, 2013 · 3 comments

Comments

@jonathanong
Copy link
Contributor

would be cool if the tests ran in the background as well (i don't know how to do that).
also, it should log in the console that the tests passed otherwise people will be like "WTF JUST HAPPENED"
@ianstormtaylor
Copy link

this seems too magicky, im not sure closing a tab is the biggest problem. should be solved by phantom to begin with

@jonathanong
Copy link
Contributor Author

Haha totally. Was just forked from another issue. I think it would only be useful for browsers you don't care much about like Opera or something.

@ianstormtaylor
Copy link

hahah my solution for those follows the "dont test it" principle :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ianstormtaylor @jonathanong