From c00920c5daf8c9b6422639c947b5f6ce28241201 Mon Sep 17 00:00:00 2001 From: Jubilee Young Date: Thu, 21 Mar 2024 12:57:39 -0700 Subject: [PATCH] Avoid noop rewrite of issues.txt This can trigger incremental rebuilds since incr doesn't realize nothing changed. --- src/tools/tidy/src/ui_tests.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/tools/tidy/src/ui_tests.rs b/src/tools/tidy/src/ui_tests.rs index 22927cffd1b9b..fa24447f69992 100644 --- a/src/tools/tidy/src/ui_tests.rs +++ b/src/tools/tidy/src/ui_tests.rs @@ -183,9 +183,10 @@ pub fn check(root_path: &Path, bless: bool, bad: &mut bool) { } }); - // if an excluded file is renamed, it must be removed from this list + // if there are any file names remaining, they were moved on the fs. + // our data must remain up to date, so it must be removed from issues.txt // do this automatically on bless, otherwise issue a tidy error - if bless { + if bless && !remaining_issue_names.is_empty() { let issues_txt_header = r#" /* ============================================================