-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TryGetTimeZoneInfo failed in version 4.0.0 #108
Comments
Hi. I'm not sure exactly what you mean, as that code isn't quite complete. If there's a particular time zone that is not found, please let me know which one. Also, please let me know which OS and version you are using, and be sure you have the latest updates. |
I've got a similar issue. I've cloned the repo and you've a couple of failing tests. I think the culprit is line 328 in TZConvert.cs I'm on windows so initially systemTimeZones is set to line 330 then sets it to the output of I fixed it locally by doing this:
|
Ahh. I messed that up indeed. I'll fix later today. Thanks! |
I have the same issue ... you can try the 'Europe/Athens' timezone that is not found ... |
@mattjohnsonpint Except this failure, could you tell me if there are any differences in names of timezones between version 3.5.0 and 4.0.0? |
It should still work, yes. The main difference in recent versions is the data has been updated, and I've dropped support for some older versions of .NET. I'm AFK much of today, but 'll have an update published later this evening (Pacific time). If this is causing an immediate problem, please use the previous versions until I can publish a fix. Thanks. |
Fixed in version 5.0.0. Would have just been 4.0.1, but I found and fixed another issue, making a breaking change for the |
Hi,
Unfortunately in a new version 4.0.0 method TryGetTimeZoneInfo works not well.
Take a look:
var timezones = TimeZoneConverter.TZConvert.KnownWindowsTimeZoneIds.ToList(); var isFound = TZConvert.TryGetTimeZoneInfo(timeZone, out var timeZone)
isFound in version 3.5.0 was TRUE, but in version 4.0.0 is here always FALSE.
The text was updated successfully, but these errors were encountered: