Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS proxy support #171

Closed
jthomperoo opened this issue Apr 5, 2022 · 0 comments · Fixed by #172
Closed

Add HTTPS proxy support #171

jthomperoo opened this issue Apr 5, 2022 · 0 comments · Fixed by #172

Comments

@jthomperoo
Copy link
Contributor

The config.go package states that:

// The http package only supports http and socks5.

I don't think this is accurate, from the Go documentation:
https://pkg.go.dev/net/http#ProxyFromEnvironment

The environment values may be either a complete URL or a "host[:port]", in which case the "http" scheme is assumed. The schemes "http", "https", and "socks5" are supported. An error is returned if the value is a different form.

I believe that HTTPS proxy support should be easy to add based on this, just needing to add https to this if statement:
https://github.com/maxmind/geoipupdate/blob/main/pkg/geoipupdate/config.go#L191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

1 participant