Async support

[gideonkorir]

Hi,

Awesome library love it. Do you have any plans for async support?

[maxtoroq]

No plans currently. I don't know enough about async. I'd accept guidance to evaluate feasibility.

[gideonkorir]

I was talking about the *.Async APIs on DbConnection e.g. connection.OpenAsync and DbCommand e.g. command.ExecuteScalaAsync.
We could have something like IAsyncDatabase that depends on the System.Data.Common APIs?

I've tried implementing it but some classes e.g. SqlSet constructor is marked internal.
Hope that makes sense. Will to help out.

[maxtoroq]

If I understand correctly, the idea is to add methods to the API that, instead of returning T, return Task<T>. What are the methods you tried to implement?

[gideonkorir]

Hi, was passed out the entire time :) I hadn't gotten to working with SqlSet and SqlTable but here is a gist on IDatabase IAsyncDatabase. Because in V6 we are using IDbConnection I added helper methods to try execute the operation in Async fashion if possible

[maxtoroq]

Hi. Decided I don't want to maintain code I don't use and don't fully understand (not a good recipe thinking long term). However, if you want to create your own project/package (e.g. DbExtensions.Async) then I'd be happy to make it easier for you, e.g. giving you access to internal members using [InternalsVisibleTo], or making non-breaking changes so the integration is easier.

[gideonkorir]

Awesome thanks, the team decided to use NPoco for the current project but I don't mind working on an Async version. I can fork the project and make the necessary changes in my fork then I can keep updating you on what changes I would need and why, does that sound ok?

[maxtoroq]

Sounds good.