Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DoctrineDbal driver has some sloppy exception handling #59

Open
borb opened this issue Jul 22, 2019 · 1 comment
Open

DoctrineDbal driver has some sloppy exception handling #59

borb opened this issue Jul 22, 2019 · 1 comment

Comments

@borb
Copy link
Contributor

borb commented Jul 22, 2019

The Dbal driver looks like it has some sloppy exception handling. Notably:

  • It tries to catch a DriverException, which has been aliased in the use statement above and likely won't work
  • We catch at least one PDOException which may not be thrown by the driver at all; we can probably integration test this to prove it
  • The trait PdoCommonMethods likely catches PDOExceptions which may never be thrown by Dbal

It looks very much like this hasn't received much testing, much less reproducible automated tests.

@kyam-mayden
Copy link
Contributor

Looking at the first issue on this list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants