Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error during transaction commit prevents transaction mode from changing #65

Open
AndyTWF opened this issue Jul 20, 2022 · 0 comments
Open

Error during transaction commit prevents transaction mode from changing #65

AndyTWF opened this issue Jul 20, 2022 · 0 comments

Comments

@AndyTWF
Copy link

AndyTWF commented Jul 20, 2022 •
edited
Loading

https://github.com/wethersherbs/pineapple/blob/26df1968f631107eb7d0fda83f821a2ff7e38978/src/DB/Driver/PdoDriver.php#L267-L280

When committing a transaction, if an error is raised the function returns without resetting the transactionOpcount. The same happens if rollback is called and an error occurs.

This prevents future calls from changing the transaction mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndyTWF