Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for MathML #1063

Merged
merged 3 commits into from
Jan 19, 2023
Merged

Add support for MathML #1063

merged 3 commits into from
Jan 19, 2023

Conversation

NiedziolkaMichal
Copy link
Member

@NiedziolkaMichal NiedziolkaMichal commented Jan 15, 2023 •
edited by dipikabh
Loading

This PR adds support for MathML, using tabbed editor.

  • Editor type mathml should be used for all MathML examples
  • Code of MathML is centered and has larger font than usual
  • Lack of support shows a warning

image

image

Edit: This PR is related to this discussion mdn/mdn-community#320.

fred-wang
fred-wang reviewed Jan 16, 2023
View reviewed changes
Copy link

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

So the idea would be to do that for all MathML examples, right?

__tests__/puppeteer-tabbed-editor.test.js Show resolved Hide resolved
editor/js/editor-libs/feature-detector.js Show resolved Hide resolved
@NiedziolkaMichal
Copy link
Member Author

Yes. There are 32 MathML elements and I think all of them should be possible to be created without any further changes.

fred-wang
fred-wang approved these changes Jan 18, 2023
View reviewed changes
Copy link

@fred-wang fred-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks the MathML-related part looks good to me. Someone who is more familiar with the editor and lib code should probably double check though.

@NiedziolkaMichal
Copy link
Member Author

@fred-wang Ok, thanks for the review.

@queengooborg queengooborg merged commit ac213d2 into mdn:main Jan 19, 2023
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

@fred-wang fred-wang fred-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NiedziolkaMichal @fred-wang @queengooborg