From 9edf1b5d54f933cf7bbad9bdba5ab8cd4fff96b2 Mon Sep 17 00:00:00 2001
From: Rob Wu <rob@robwu.nl>
Date: Thu, 18 Mar 2021 17:48:06 +0100
Subject: [PATCH] Fix compat notes for Firefox of permissions.request (#9374)

- Removed compat notes at Firefox for Android. The notes aren't
  relevant, e.g. sidebars were never supported on Android.
- Fix out-of-date claims about bugs in support on Firefox desktop,
  permissions can be requested from a popup since Firefox 75.
---
 webextensions/api/permissions.json | 39 +++++++++---------------------
 1 file changed, 11 insertions(+), 28 deletions(-)

diff --git a/webextensions/api/permissions.json b/webextensions/api/permissions.json
index 4305d83f377256..98344705bddcc2 100644
--- a/webextensions/api/permissions.json
+++ b/webextensions/api/permissions.json
@@ -165,34 +165,17 @@
               "edge": {
                 "version_added": "79"
               },
-              "firefox": [
-                {
-                  "version_added": "55",
-                  "notes": [
-                    "The user will be prompted again for permissions that have been previously granted and then removed.",
-                    "It's not possible to request permissions from a popup or a sidebar document."
-                  ]
-                },
-                {
-                  "version_added": "56",
-                  "version_removed": "61",
-                  "notes": "It's not possible to request permissions from an options page that's embedded in about:addons. To request permissions from an options page, set the <code>open_in_tab</code> property in the <code>options_ui</code> manifest key, so the options page opens in its own tab."
-                }
-              ],
-              "firefox_android": [
-                {
-                  "version_added": "55",
-                  "notes": [
-                    "The user will be prompted again for permissions that have been previously granted and then removed.",
-                    "It's not possible to request permissions from a popup or a sidebar document."
-                  ]
-                },
-                {
-                  "version_added": "56",
-                  "version_removed": "61",
-                  "notes": "It's not possible to request permissions from an options page that's embedded in about:addons. To request permissions from an options page, set the <code>open_in_tab</code> property in the <code>options_ui</code> manifest key, so the options page opens in its own tab."
-                }
-              ],
+              "firefox": {
+                "version_added": "55",
+                "notes": [
+                  "It's not possible to request permissions from a sidebar document (<a href='https://bugzil.la/1493396'>bug 1493396</a>).",
+                  "Before version 75, permissions cannot be requested from popup panels (see <a href='https://bugzil.la/1432083'>bug 1432083</a>).",
+                  "Before version 61, permissions cannot be requested from options pages embedded in <code>about:addons</code> (see <a href='https://bugzil.la/1382953'>bug 1382953</a>)."
+                ]
+              },
+              "firefox_android": {
+                "version_added": true
+              },
               "opera": {
                 "version_added": true
               },