You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ranged values are currently allowed for browser versions released two years or earlier.
What behavior were you expecting?
If you set the linter to four years or earlier, it still passes. We should enforce that, so that we can make the guarantee that BCD will always report a real (non-ranged) version for as many years as possible.
What version(s) of BCD is the issue present in?
The current BCD release
The current version of the main branch
Do you have anything more you want to share?
It doesn't pass for:
5 years: 832 errors (≤79 for Edge, ≤83 for Chrome, ≤72 for Firefox, and ≤13.1 for Safari would no longer be allowed)
6 years: 913 errors (≤18 for Edge would no longer be allowed)
7 years: 930 errors
8 years: 953 errors
9 years: 957 errors
10 years: 1793 errors (≤37 for WebView Android would no longer be allowed)
We should enforce that, so that we can make the guarantee that BCD will always report a real (non-ranged) version for as many years as possible.
Agreed. Though I'd like to suggest going one step further and pinning those versions that define the 4-year cut off, rather than having a rolling X-year window. That way no new uncertainties would emerge (e.g., a year from now, you wouldn't be allowed to add a ranged value to a 2020 release).
Unfortunately, a recent update to the web extensions data has now introduced a range that is within two years, so we are no longer able to switch to a longer date at this time. Currently, it is only one single range, so we may be able to prioritize researching a proper version number and replace the range.
Elchi3
changed the title
Range linter: Set to four years
Range linter: Disallow ranged values after 2020-01-01
Aug 19, 2024
What type of issue is this?
Linter issue
What is the issue?
Ranged values are currently allowed for browser versions released two years or earlier.
What behavior were you expecting?
If you set the linter to four years or earlier, it still passes. We should enforce that, so that we can make the guarantee that BCD will always report a real (non-ranged) version for as many years as possible.
What version(s) of BCD is the issue present in?
main
branchDo you have anything more you want to share?
It doesn't pass for:
cc @foolip @ddbeck
The text was updated successfully, but these errors were encountered: