-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(css): grid-template alternatives for IE 10+ #6599
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR, @kripod. I think this is the right thing to do in general, but there's some specifics here that need some attention.
First, we seem to have dedicated files for -ms-grid-columns
and -ms-grid-rows
. I think those ought to be removed as well, since the new data here duplicates that.
Second, I'm pretty sure the -ms-
prefixes went away in Edge 79. Would you be willing to confirm that they're no longer supported and set the version numbers (12-??) for Edge accordingly?
Thank you again for your help on this!
Thank you for the review! I've updated the PR as requested, incorporating previously available data for Edge 12–16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, @kripod I think I explained myself poorly. It looks like Edge continued to support the -ms-
prefixed properties until Edge 79 (that is, "version_added": "12"
and "version_removed": "79"
). Can you reinstate that data for Edge? Then we can merge this. Thank you!
Oh I see, you're right, thank you! I've just updated the PR to fix those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect. Thank you, @kripod! 🎉
Please see the note about the alternative properties in this CSS-Tricks article for further details.
A checklist to help your pull request get merged faster: