Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename api.HTMLImageElement.lowSrc -> lowsrc #7472

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

queengooborg
Copy link
Contributor

This PR corrects capitalization for the HTMLImageElement API's lowsrc feature.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 23, 2020
@foolip
Copy link
Contributor

foolip commented Nov 23, 2020

This looks good, but I'm not sure how to do the rename dance with https://wiki.developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/lowSrc in a way that doesn't break the compat table there for longer than necessary. @ddbeck can you advise?

@foolip foolip requested a review from ddbeck November 24, 2020 14:06
@foolip
Copy link
Contributor

foolip commented Nov 24, 2020

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 24, 2020

@foolip Since I'll see this when I do the release notes anyway, I'll update the compat macro on the page at that time. Is that satisfactory? Do we need anything else to merge this?

@foolip
Copy link
Contributor

foolip commented Nov 24, 2020

@ddbeck that sounds good, getting the timing right is the only thing I'm concerned about, since the worst case is that the compat table is broken for a week, and the best case is that nobody notices at all :)

I'll go ahead and merge this then.

@foolip foolip merged commit 94ac44f into mdn:master Nov 24, 2020
@queengooborg queengooborg deleted the api/HTMLImageElement-lowsrc branch November 24, 2020 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants