Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP > Content Length : Added to safelisted response header in specific versions #9300

Closed
hamishwillee opened this issue Mar 1, 2021 · 5 comments · Fixed by #9456
Closed
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP

Comments

@hamishwillee
Copy link
Collaborator

The Content-Length HTTP response header got added to the CORS safelisted response headers in a late revision to the spec.

So the question is, "what is the best way to add this to BCD". My thought was as a subfeature "cors_response_safelist" with FF87 and Safari added (either with version if I can find it or true, the rest null). Is that reasonable?

Who can we ask about Chrome/Blink?

@ddbeck Advice appreciated please.

@queengooborg queengooborg added the data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP label Mar 1, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Mar 2, 2021

  • Chrome - can't find any mention.

For Chrome, I found this: https://storage.googleapis.com/chromium-find-releases-static/5e9.html#5e97971dd8d45819d5758b2a5fd53ebdce7e7138

So the question is, "what is the best way to add this to BCD". My thought was as a subfeature "cors_response_safelist" with FF87 and Safari added (either with version if I can find it or true, the rest null). Is that reasonable?

Do you mean a subfeature of http.headers.Access-Control-Expose-Headers or some other feature?

@ddbeck
Copy link
Collaborator

ddbeck commented Mar 2, 2021

Oh and this one I wasn't able to sort out. A shame Microsoft took that site offline. Ideally, a test case that we could run on old versions in BrowserStack or SauceLabs would settle it. If that's too much hassle, ≤79 would be satisfactory.

@hamishwillee
Copy link
Collaborator Author

Do you mean a subfeature of http.headers.Access-Control-Expose-Headers or some other feature?

My thinking was to add it as a subfeature of Content-Length. But probably it should be added to all of the safelisted headers: Cache-Control, Content-Language, Content-Length, Content-Type, Expires, Last-Modified, Pragma.

Currently the information is in a table at the top of pages, but would not hurt for it to be in BCD, especially now this is a compatibility thing.

image

@ddbeck
Copy link
Collaborator

ddbeck commented Mar 9, 2021

OK. That makes sense. I'd welcome a PR that does this for one or two of the headers, so we can see what it looks like before filling them out for every single one.

@hamishwillee
Copy link
Collaborator Author

Excellent. Test case in #9456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http 🚠 Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants