Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KeyboardEvent.which and MouseEvent.which #12185

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Remove KeyboardEvent.which and MouseEvent.which #12185

merged 1 commit into from
Sep 8, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Aug 26, 2021

UIEvent.which is already in the data, so update that to reflect the
partial support from when which was on KeyboardEvent and MouseEvent.

The existing data from MouseEvent is not perfectly preserved, in
particular the early Opera and Safari versions have not been verified,
so instead ranges are used in the merged data.

@foolip
Remove KeyboardEvent.which and MouseEvent.which
70686af 
UIEvent.which is already in the data, so update that to reflect the
partial support from when `which` was on KeyboardEvent and MouseEvent.

The existing data from MouseEvent is not perfectly preserved, in
particular the early Opera and Safari versions have not been verified,
so instead ranges are used in the merged data.
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 26, 2021
@foolip foolip added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 26, 2021
@foolip
Copy link
Contributor Author

foolip commented Aug 26, 2021

This needs updating on MDN too:
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/which
https://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/which

@queengooborg queengooborg mentioned this pull request Sep 8, 2021
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Sep 8, 2021
queengooborg
queengooborg approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the content PR all done for this, and it has now been merged -- the BCD updates here are LGTM! 👍

@queengooborg queengooborg merged commit 856a46a into main Sep 8, 2021
@queengooborg queengooborg deleted the uievent-which branch September 8, 2021 12:09
@foolip
Copy link
Contributor Author

foolip commented Sep 9, 2021

Thanks @queengooborg!

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Sep 10, 2021
@ddbeck
Add release note for mdn#12185
2eb2e8b
ddbeck added a commit that referenced this pull request Sep 10, 2021
@ddbeck
Prepare release v4.0.3 (#12342)
39ecbba 
* Bump version to v4.0.3

* Hoist known issues

* Add release note for #12230

* Add release note for #12276

* Add release note for #12185

* Add release stats

* Add release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foolip @queengooborg @ddbeck