FF supports navigator.share behind pref #12194

hamishwillee · 2021-08-27T02:41:06Z

Navigator.share() was marked false for FireFox desktop. However testing shows that it does work for desktop Windows (at least). I think it was added in FF71 in this bug behind the preference dom.webshare.enabled.
Note that FF android is not blocked by this preference.

I also did some testing and verified that Navigator.share() and Navigator.canShare() work on Windows Opera and Edge, and also Opera Android. I have guessed the versions for desktop match Chrome (but without the partial implementation warning due, I think, to MacOS issues).

Upshot, those changes might perhaps revert to true if you think this is not a safe assumption.

FYI these methods are protected by web-share permission. I have not added subfeatures for that, because I don't know if it is a compatibility issue (at all).

api/Navigator.json

hamishwillee · 2021-08-30T05:44:05Z

@ddbeck Further to this, the webshare spec states that navigator.share() should support sharing a base set of data types that might be shared, which includes: title, text, url, an array files

I just found this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1635700 which indicates that FF does not support file sharing.

Should we note this by marking the support in firefox as partial OR by adding a subfeature for files, url, whatever. Thoughts?

@saschanaz Do you know when/if this feature is expected for Firefox?

ddbeck · 2021-09-08T17:25:35Z

but without the partial implementation warning due, I think, to MacOS issues

Sorry, I didn't quite follow this. You didn't mark the Mac partial implementation because you didn't test it? Or had reason to believe that this is a Chrome-specific limitation? The rest of this seems fine to me, I just want to figure out when/where we ought to be copying notes.

hamishwillee · 2021-09-10T00:38:23Z

but without the partial implementation warning due, I think, to MacOS issues

Coming back to this after a couple of weeks - yes, that note is gibberish sorry.

What I am saying is that Chrome marks canShare() support as partial - should I copy this "partial" to the other chromiums?

The only reason I am questioning this is because I don't know the reason this was marked as partial support in the first place. If this could be because it is not supported on macOS then I could omit this caveat on android platforms.

I guess I should add "partial" and the note for Opera though, as that runs on Mac.

Does the question make sense now?

ddbeck · 2021-09-10T17:03:59Z

Does the question make sense now?

Yes, this makes sense now. Reading the linked bug, it appears to be Mac specific, so I'd copy it to Edge and Opera. 👍

hamishwillee · 2021-09-13T01:43:40Z

Thanks @ddbeck ,
I've added the note and partial_implementation to opera and Edge. Should be good now.

saschanaz · 2021-09-13T13:56:01Z

I just found this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1635700 which indicates that FF does not support file sharing.

Should we note this by marking the support in firefox as partial OR by adding a subfeature for files, url, whatever. Thoughts?

@saschanaz Do you know when/if this feature is expected for Firefox?

It's not expected anytime soon, and files support is added later to the spec separately, so 👍 to add a separate files data.

saschanaz · 2021-09-13T13:58:14Z

And also probably a good chance to use preview since it's enabled only on Nightly/early beta.

hamishwillee · 2021-09-13T23:28:59Z

@ddbeck @saschanaz OK, I added a files subfeature with versions based on

Safari/Safari iOS in v15 - https://blog.bitsrc.io/sharing-files-from-ios-15-safari-to-apps-using-web-share-c0e98f6a4971 [Note, that files may have been in Safari v14 behind a flag, but I couldn't find the information and not sure it is necessary?]
Chrome https://www.chromestatus.com/feature/4777349178458112 - v76 android, 89 Chromium. Rolled it out everwhere.

Question. Could/should we add subfeatures for text as well? The reason I ask is that Firefox for android does not support text sharing (at the moment captured with a note).

And also probably a good chance to use preview since it's enabled only on Nightly/early beta.

@ddbeck How do you do both a preference and a preview version? This is what it looks like now

            "firefox": {
              "version_added": "71",
              "flags": [
                {
                  "type": "preference",
                  "name": "#dom.webshare.enabled",
                  "value_to_set": "enabled"
                }
              ]
            },

This was added in nightly in FF92 - see https://bugzilla.mozilla.org/show_bug.cgi?id=1641280 . I think it was only added for Windows though - dunno if that matters (i.e. it doesn't if preview is assumed to be Windows for Firefox).
I tried a few variants like this, but it can't cope with "preview". Ideas?

            "firefox": [
              {
                "version_added": "preview"
              },
              {
                "version_added": "71",
                "version_removed": "91",
                "flags": [
                  {
                    "type": "preference",
                    "name": "#dom.webshare.enabled",
                    "value_to_set": "enabled"
                  }
                ]
              }
            ],

ddbeck

Thanks, Hamish. Some general commentary here and a specific suggestion in a line comment.

Could/should we add subfeatures for text as well? The reason I ask is that Firefox for android does not support text sharing (at the moment captured with a note).

Yes, I endorse this. 👍

This was added in nightly in FF92 - see https://bugzilla.mozilla.org/show_bug.cgi?id=1641280 . I think it was only added for Windows though - dunno if that matters (i.e. it doesn't if preview is assumed to be Windows for Firefox).
I tried a few variants like this, but it can't cope with "preview". Ideas?

There's a lot to unpack here:

Operating system limitations imply partial_implementation. "preview" shouldn't change this.
You said 'it can't cope with "preview"'. Sorry if I'm being dense, but can you elaborate on this? What's "it" and what is not coping, in this situation?
Based on the example, I'd interpret that to mean:
- In Nightly-only, it's enabled by default.
- In 71-91, it's available behind a pref.
- In 92+ (stable), it's no longer supported in anyway.
Is that the story you want to tell? If it isn't, what is?

api/Navigator.json

hamishwillee · 2021-09-15T22:46:50Z

Thanks, all helpful. I'll make the required changes tomorrow.

@ddbeck

By "can't cope with preview", I mean I tried the following and got an error related to using the term "preview". I tried a number of other variants, and they gave me an error warning too. So my question was "what does it have to look like". I will try this again tomorrow and post the actual error for this to provide more data.

            "firefox": [
              {
                "version_added": "preview"
              },
              {
                "version_added": "71",
                "version_removed": "91",
                "flags": [
                  {
                    "type": "preference",
                    "name": "#dom.webshare.enabled",
                    "value_to_set": "enabled"
                  }
                ]
              }
            ],

With respect to the story ...

The story that I "know" is that prior to FF92 it is available behind pref ( 71-91), in FF92 it is available in Nightly by default and behind the pref for release.

The restriction to Windows confuses me. My original understanding was that the preference change in Nightly was only for Windows, but that doesn't make much sense.

@saschanaz is this a partial implementation? - ie this only works on Windows, or is it that we only enabled it for Windows, or is it that it behaves differently on Windows? Can you confirm?

saschanaz · 2021-09-16T00:07:05Z

@saschanaz is this a partial implementation? - ie this only works on Windows, or is it that we only enabled it for Windows, or is it that it behaves differently on Windows? Can you confirm?

It's enabled on Windows and Android, and should generally work same way on both, except a nit: Windows does not support tracking share action properly, so it resolves after opening the share popup, not after completing the share action. (Same for Chrome)

hamishwillee · 2021-09-17T00:23:56Z

except a nit: Windows does not support tracking share action properly, so it resolves after opening the share popup, not after completing the share action. (Same for Chrome)

@saschanaz Ah, that wasn't clear to me, and makes this wrong: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/share

My understanding was that is that this should be re-written as:

On Windows the method resolves a Promise with undefined as soon as the share popup has launched. On other platforms it resolves the promise with undefined once data is successfully passed to the share target.

Is that correct? Note the assertions:

in both cases it resolves with undefined.
resolved when "data is passed to the share target" (i.e. bluetooth) NOT when actually sent/recieved. So completion on Android means "prompt has closed and data sent to the OS API that does the sending"

I will correct the docs in line with your comment, but NOT record this nit as a compatibility issue in BCD.

hamishwillee · 2021-09-17T00:35:53Z

@ddbeck I have added data_parameter_files and data_parameter_text to share and canShare. These mirror each other. The Chrome mac bug refers to files and it isn't clear if it also applies to text - but it might so I have left that in.

With respect to adding preview, I still don't get how to do that. The story I am trying to tell is that it was added in version 71 behind a preference. From version 92 it is released (no pref required) in Nightly.

I tried the following, but get Error: Invalid argument not valid semver ('preview' received)

            "firefox": [
              {
                "version_added": "preview"
              },
              {
                "version_added": "71",
                "flags": [
                  {
                    "type": "preference",
                    "name": "#dom.webshare.enabled",
                    "value_to_set": "enabled"
                  }
                ]
              }
            ],

saschanaz · 2021-09-17T11:44:13Z

resolved when "data is passed to the share target" (i.e. bluetooth) NOT when actually sent/recieved.

I don't think this can be a strong assertion as each OS may behave different. But correct at least on Android.

hamishwillee · 2021-10-01T02:45:54Z

@ddbeck When you get a chance, this needs re-review. As discussed, this is not an immediate priority, just keeping it visible.

ddbeck

Thanks, Hamish. Some suggestions in line comments.

Regarding Error: Invalid argument not valid semver ('preview' received), that's a bug. I'll open an issue about it.

api/Navigator.json

ddbeck · 2021-10-01T10:58:26Z

api/Navigator.json

            },
            "firefox_android": {
              "version_added": "79",
              "partial_implementation": true,
-              "notes": "Firefox for Android does not support sharing files or text."
+              "notes": "Firefox for Android does not support sharing text or files."


Since we have the subfeatures now, we can drop this note entirely

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>

hamishwillee · 2021-10-03T23:40:13Z

@ddbeck Thanks for the review. I've "accepted all".

ddbeck

Thank you! 🎉

FF supports navigator.share behind pref

2fc36be

github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Aug 27, 2021

hamishwillee commented Aug 27, 2021

View reviewed changes

api/Navigator.json Outdated Show resolved Hide resolved

hamishwillee mentioned this pull request Aug 27, 2021

[Dropped] [webAPI] Web Share update mdn/content#7749

Closed

7 tasks

mark share/canShare as standard and not experimental

73e123a

hamishwillee commented Aug 27, 2021

View reviewed changes

api/Navigator.json Show resolved Hide resolved

hamishwillee commented Aug 27, 2021

View reviewed changes

api/Navigator.json Show resolved Hide resolved

Add canShare spec_url

3b7bd3b

ddbeck self-requested a review September 6, 2021 13:43

Update api/Navigator.json

068ae5d

Add macOS note and partial implementation for edge/opera

65d5226

Add files as a subfeature

0caebe2

ddbeck requested changes Sep 15, 2021

View reviewed changes

api/Navigator.json Outdated Show resolved Hide resolved

hamishwillee added 2 commits September 17, 2021 10:09

Add navigator share data_text_parameter and data_file_parameter

5794242

Mirror data params to canShare

c4c726f

hamishwillee mentioned this pull request Sep 19, 2021

navigator.share() resolves at different point for Windows mdn/content#9076

Merged

ddbeck self-requested a review September 23, 2021 08:13

lukewarlow mentioned this pull request Sep 26, 2021

Update Firefox support for feature-policy #12548

Merged

ddbeck requested changes Oct 1, 2021

View reviewed changes

ddbeck mentioned this pull request Oct 1, 2021

Fix preview consistency check #12673

Merged

hamishwillee and others added 3 commits October 4, 2021 10:34

Update api/Navigator.json

6339480

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>

partial_implementation for macOS limitation - from code review

90b42ba

Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>

Remove superseded note about data/text support

fdcef8d

hamishwillee requested a review from ddbeck October 3, 2021 23:39

ddbeck approved these changes Oct 7, 2021

View reviewed changes

ddbeck merged commit 2611b28 into mdn:main Oct 7, 2021

hamishwillee deleted the navigator_webshare branch October 7, 2021 22:47

queengooborg mentioned this pull request Apr 1, 2022

api.Navigator.share - filesArray doesn't have support on IOS #12064

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FF supports navigator.share behind pref #12194

FF supports navigator.share behind pref #12194

hamishwillee commented Aug 27, 2021 •

edited

Loading

hamishwillee commented Aug 30, 2021

ddbeck commented Sep 8, 2021

hamishwillee commented Sep 10, 2021

ddbeck commented Sep 10, 2021

hamishwillee commented Sep 13, 2021

saschanaz commented Sep 13, 2021

saschanaz commented Sep 13, 2021

hamishwillee commented Sep 13, 2021 •

edited

Loading

ddbeck left a comment

hamishwillee commented Sep 15, 2021

saschanaz commented Sep 16, 2021 •

edited

Loading

hamishwillee commented Sep 17, 2021 •

edited

Loading

hamishwillee commented Sep 17, 2021

saschanaz commented Sep 17, 2021

hamishwillee commented Oct 1, 2021

ddbeck left a comment

ddbeck Oct 1, 2021

hamishwillee commented Oct 3, 2021

ddbeck left a comment

FF supports navigator.share behind pref #12194

FF supports navigator.share behind pref #12194

Conversation

hamishwillee commented Aug 27, 2021 • edited Loading

hamishwillee commented Aug 30, 2021

ddbeck commented Sep 8, 2021

hamishwillee commented Sep 10, 2021

ddbeck commented Sep 10, 2021

hamishwillee commented Sep 13, 2021

saschanaz commented Sep 13, 2021

saschanaz commented Sep 13, 2021

hamishwillee commented Sep 13, 2021 • edited Loading

ddbeck left a comment

Choose a reason for hiding this comment

hamishwillee commented Sep 15, 2021

saschanaz commented Sep 16, 2021 • edited Loading

hamishwillee commented Sep 17, 2021 • edited Loading

hamishwillee commented Sep 17, 2021

saschanaz commented Sep 17, 2021

hamishwillee commented Oct 1, 2021

ddbeck left a comment

Choose a reason for hiding this comment

ddbeck Oct 1, 2021

Choose a reason for hiding this comment

hamishwillee commented Oct 3, 2021

ddbeck left a comment

Choose a reason for hiding this comment

hamishwillee commented Aug 27, 2021 •

edited

Loading

hamishwillee commented Sep 13, 2021 •

edited

Loading

saschanaz commented Sep 16, 2021 •

edited

Loading

hamishwillee commented Sep 17, 2021 •

edited

Loading