From 000273fdce1aee0b2ea531b429c654244c2534eb Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Sun, 1 Dec 2024 09:48:19 +0000 Subject: [PATCH 1/9] Add data point for improved error reporting for large value read failures --- api/IDBRequest.json | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 9045d929dd7369..a4d1a974fa5c30 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -182,6 +182,50 @@ "standard_track": true, "deprecated": false } + }, + "improved_reporting_large_value_read_failures": { + "__compat": { + "description": "Improved reporting for large value read failures", + "support": { + "chrome": [ + { + "version_added": "132", + "notes": "Throws a `NotReadableError` for unrecoverable large value read failures, and an `UnknownError` for transient large value read failures, with improved error messages." + }, + { + "version_added": "130", + "partial_implementation": true, + "notes": "Throws a `NotFoundError` for unrecoverable large value read failures, and a `DataError` for transient large value read failures." + } + ], + "chrome_android": "mirror", + "edge": { + "version_added": false + }, + "firefox": { + "version_added": false + }, + "firefox_android": "mirror", + "ie": { + "version_added": false + }, + "oculus": "mirror", + "opera": "mirror", + "opera_android": "mirror", + "safari": { + "version_added": false + }, + "safari_ios": "mirror", + "samsunginternet_android": "mirror", + "webview_android": "mirror", + "webview_ios": "mirror" + }, + "status": { + "experimental": true, + "standard_track": true, + "deprecated": false + } + } } } }, From 656605e3324a436c12c7668fcb196c1193b684c6 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Wed, 11 Dec 2024 12:38:27 +0000 Subject: [PATCH 2/9] Make sure some updates based on review comments --- api/IDBRequest.json | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index a4d1a974fa5c30..acc02c26704dec 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -183,19 +183,20 @@ "deprecated": false } }, - "improved_reporting_large_value_read_failures": { + "read_errors": { "__compat": { - "description": "Improved reporting for large value read failures", + "description": "Improved reporting for read errors", + "spec_url": "https://w3c.github.io/IndexedDB/#:~:text=NotReadableError", "support": { "chrome": [ { "version_added": "132", - "notes": "Throws a `NotReadableError` for unrecoverable large value read failures, and an `UnknownError` for transient large value read failures, with improved error messages." + "notes": "Returns a `NotReadableError` for unrecoverable read errors, and an `UnknownError` for transient read errors." }, { "version_added": "130", "partial_implementation": true, - "notes": "Throws a `NotFoundError` for unrecoverable large value read failures, and a `DataError` for transient large value read failures." + "notes": "Returns a `NotFoundError` for unrecoverable read errors, and a `DataError` for transient read errors." } ], "chrome_android": "mirror", From 90311d3dc3e2740889d739f5cf89214fa5e634e1 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Wed, 11 Dec 2024 12:47:06 +0000 Subject: [PATCH 3/9] Make some updates based on review comments --- api/IDBRequest.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index acc02c26704dec..3ce671b6928569 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -191,12 +191,12 @@ "chrome": [ { "version_added": "132", - "notes": "Returns a `NotReadableError` for unrecoverable read errors, and an `UnknownError` for transient read errors." + "notes": "Returns a `NotReadableError` exception for unrecoverable read errors, and an `UnknownError` for transient read errors." }, { "version_added": "130", "partial_implementation": true, - "notes": "Returns a `NotFoundError` for unrecoverable read errors, and a `DataError` for transient read errors." + "notes": "Returns a `NotFoundError` exception for unrecoverable read errors, and a `DataError` for transient read errors." } ], "chrome_android": "mirror", From 7e1ca94a542b35c3205325349af1c9b8873a9c14 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Thu, 12 Dec 2024 10:03:42 +0000 Subject: [PATCH 4/9] Update feature name to the suggestion in the code review --- api/IDBRequest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 3ce671b6928569..77d23f7a05754b 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -183,7 +183,7 @@ "deprecated": false } }, - "read_errors": { + "transient_unrecoverable_read_errors": { "__compat": { "description": "Improved reporting for read errors", "spec_url": "https://w3c.github.io/IndexedDB/#:~:text=NotReadableError", From f790e32fef26d1e7c2e995ebf445ff45c558368c Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Fri, 13 Dec 2024 14:07:50 +0000 Subject: [PATCH 5/9] Update api/IDBRequest.json Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com> --- api/IDBRequest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 77d23f7a05754b..9e223f82218f43 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -204,7 +204,7 @@ "version_added": false }, "firefox": { - "version_added": false + "version_added": "14" }, "firefox_android": "mirror", "ie": { From 3c16336ab0c01b05346fcbeb0b6383284b74f851 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Fri, 13 Dec 2024 14:08:07 +0000 Subject: [PATCH 6/9] Update api/IDBRequest.json Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com> --- api/IDBRequest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 9e223f82218f43..62b84f4f21e7b5 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -214,7 +214,7 @@ "opera": "mirror", "opera_android": "mirror", "safari": { - "version_added": false + "version_added": "7" }, "safari_ios": "mirror", "samsunginternet_android": "mirror", From e8d8bb919cebd597e8204a20d1831717e023f03b Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Fri, 13 Dec 2024 14:08:21 +0000 Subject: [PATCH 7/9] Update api/IDBRequest.json Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com> --- api/IDBRequest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 62b84f4f21e7b5..45b6fb78d70112 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -222,7 +222,7 @@ "webview_ios": "mirror" }, "status": { - "experimental": true, + "experimental": false, "standard_track": true, "deprecated": false } From b8f86c92e999b84a97e46828738d264184e8eb78 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Fri, 13 Dec 2024 14:08:35 +0000 Subject: [PATCH 8/9] Update api/IDBRequest.json Co-authored-by: Florian Scholz --- api/IDBRequest.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 45b6fb78d70112..064b568a39c205 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -185,7 +185,7 @@ }, "transient_unrecoverable_read_errors": { "__compat": { - "description": "Improved reporting for read errors", + "description": "Transient and unrecoverable read errors", "spec_url": "https://w3c.github.io/IndexedDB/#:~:text=NotReadableError", "support": { "chrome": [ From aeade4b54da46043195a28ee8f9ffda634756556 Mon Sep 17 00:00:00 2001 From: Chris Mills Date: Fri, 13 Dec 2024 14:20:22 +0000 Subject: [PATCH 9/9] correct nesting level and support versions --- api/IDBRequest.json | 86 +++++++++++++++++++++++---------------------- 1 file changed, 44 insertions(+), 42 deletions(-) diff --git a/api/IDBRequest.json b/api/IDBRequest.json index 064b568a39c205..7bb813a6fc95b7 100644 --- a/api/IDBRequest.json +++ b/api/IDBRequest.json @@ -182,50 +182,52 @@ "standard_track": true, "deprecated": false } - }, - "transient_unrecoverable_read_errors": { - "__compat": { - "description": "Transient and unrecoverable read errors", - "spec_url": "https://w3c.github.io/IndexedDB/#:~:text=NotReadableError", - "support": { - "chrome": [ - { - "version_added": "132", - "notes": "Returns a `NotReadableError` exception for unrecoverable read errors, and an `UnknownError` for transient read errors." - }, - { - "version_added": "130", - "partial_implementation": true, - "notes": "Returns a `NotFoundError` exception for unrecoverable read errors, and a `DataError` for transient read errors." - } - ], - "chrome_android": "mirror", - "edge": { - "version_added": false - }, - "firefox": { - "version_added": "14" - }, - "firefox_android": "mirror", - "ie": { - "version_added": false - }, - "oculus": "mirror", - "opera": "mirror", - "opera_android": "mirror", - "safari": { - "version_added": "7" + } + }, + "transient_unrecoverable_read_errors": { + "__compat": { + "description": "Transient and unrecoverable read errors", + "spec_url": "https://w3c.github.io/IndexedDB/#:~:text=NotReadableError", + "support": { + "chrome": [ + { + "version_added": "132", + "notes": "Returns a `NotReadableError` exception for unrecoverable read errors, and an `UnknownError` for transient read errors." }, - "safari_ios": "mirror", - "samsunginternet_android": "mirror", - "webview_android": "mirror", - "webview_ios": "mirror" + { + "version_added": "130", + "partial_implementation": true, + "notes": "Returns a `NotFoundError` exception for unrecoverable read errors, and a `DataError` for transient read errors." + } + ], + "chrome_android": "mirror", + "edge": { + "version_added": false + }, + "firefox": { + "version_added": "14" + }, + "firefox_android": { + "version_added": "22" }, - "status": { - "experimental": false, - "standard_track": true, - "deprecated": false - } + "ie": { + "version_added": false + }, + "oculus": "mirror", + "opera": "mirror", + "opera_android": "mirror", + "safari": { + "version_added": "8" + }, + "safari_ios": "mirror", + "samsunginternet_android": "mirror", + "webview_android": "mirror", + "webview_ios": "mirror" + }, + "status": { + "experimental": false, + "standard_track": true, + "deprecated": false } } }