Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebAPI] Midi Support added #12792

Closed
4 of 7 tasks
hamishwillee opened this issue Feb 7, 2022 · 24 comments
Closed
4 of 7 tasks

[WebAPI] Midi Support added #12792

hamishwillee opened this issue Feb 7, 2022 · 24 comments
Assignees
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers. on hold Waiting on something else before this can be moved forward.

Comments

@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 7, 2022

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Related Gecko bugs

Other

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 7, 2022
@sideshowbarker sideshowbarker added Content:WebAPI Web API docs and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 7, 2022
@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Feb 7, 2022

@Rumyra I've converted the WebMidi project notes into this issue. Right now my testing shows that it works on FF60 on windows, which is a bit odd because the implication of the thread is that support should appear in FF97. Anyway, as a result I'm querying what exactly is delivered in https://bugzilla.mozilla.org/show_bug.cgi?id=836897#c117.

Looking at this there are already some docs here: https://developer.mozilla.org/en-US/docs/Web/API/Web_MIDI_API. I expect the task here would be

@hamishwillee
Copy link
Collaborator Author

hamishwillee commented Feb 7, 2022

Edited. As discussed, I will sort out the BCD, but everything else is for you @Rumyra . Of course you can shift things back to me if you want, and note that at time of writing this is not yet released in FF98. If it is released, not that this won't be for Android or iOS as no backends exist.

@hamishwillee
Copy link
Collaborator Author

@Rumyra OK, BCD for WebMidi for FF97 sorted in mdn/browser-compat-data#14874 - essentially we are considering to have been added "new" on behind a preference (ignoring previous dummy implementation) on FF. FF for android is still false, because a) preferences not set on android, b)there is no android backend.

So in FF98 the plan is that the preference will be removed. When that happens I intend to add a new entry for FF removing the preference. FF for Android will remain false until there is a backend.

Please ping me if you note that this has shipped in FF98 so I can do the next bit.

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 21, 2022

OK @hamishwillee thank you 👍 I'm going to move this to 'In Progress' as I plan to start work on the docs tomorrow

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 22, 2022

@hamishwillee could you update the bcd for navigator.requestMIDIAccess as per 97 above here: https://github.com/mdn/browser-compat-data/blob/main/api/Navigator.json#L3160

@Rumyra
Copy link
Collaborator

Rumyra commented Feb 24, 2022

NB it looks as though this will be rolled into FF99 - I plan to get the docs work done now, but I'll keep my eye on it release info 👍

@hamishwillee
Copy link
Collaborator Author

@Rumyra Excellent. BCD update in mdn/browser-compat-data#15152.

Excellent to get docs done and close this. Then we can start fresh on the release in (hopefully) FF99

@hamishwillee
Copy link
Collaborator Author

@Rumyra Further BCD update in FF99: https://bugzilla.mozilla.org/show_bug.cgi?id=1757153

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 1, 2022

@hamishwillee
Copy link
Collaborator Author

FYI @Rumyra

  • I've done FF99 BCD work for the release and for adding secure context.
  • Updated the docs a bit for secure context: Nav requestmidi updates #13479
  • NOT yet removed experimental tagging from docs (but have in BCD). Figure we can wait on BCD before doing this.
  • NOT done release note and removed from experimental features.

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 4, 2022

Thanks @hamishwillee :) - I've only just created a pr for the edits to 98 release notes and updating 99 & 100 - so it's probably best to wait for that to go through before updating anyway 👍

@hamishwillee
Copy link
Collaborator Author

Cool. I'm leaving to you, but I'll track the BCD stuff.

@hamishwillee
Copy link
Collaborator Author

@Rumyra Just FYI, and you might already have known this, but access to web midi is gated on a site permission add on. This is something I had not heard of. Some discussion here: https://bugzilla.mozilla.org/show_bug.cgi?id=1752906

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 8, 2022

Yes I am - thanks @hamishwillee - I think I'll tackle the events pages first (move to new format) but I want to update the api landing page - which I think will be a good page to explain this 👍

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 29, 2022

This is mostly done - I just need to go through each page & remove any experimental notes & add rel note

In regards to the list above:

Update with a live example (makes testing easier)

I don't think a live example would be useful here - the reader would need a midi device for it to make any sense.

Maybe add link to this page, which makes a nice test tool: https://blog.karimratib.me/demos/sheetplayer/

This doesn't actually use this api - Web MIDI just supports inputs from MIDI devices not the file format.

@Rumyra
Copy link
Collaborator

Rumyra commented Mar 30, 2022

Looks like this is getting pushed to FF100 - I'll check properly tomorrow

@hamishwillee
Copy link
Collaborator Author

@Rumyra You were right https://bugzilla.mozilla.org/show_bug.cgi?id=1752906#c30 - FF100.

BCD updated -mdn/browser-compat-data#15610 - I am assuming you will let me know if anything more is required of me on this one :-)

@Rumyra
Copy link
Collaborator

Rumyra commented Apr 4, 2022

Amazing @hamishwillee - that was precisely the thing that was needed. Luckily I hadn't done the rel note yet so I'll just push the few last tasks for this to this coming month 👍

@Rumyra
Copy link
Collaborator

Rumyra commented Apr 28, 2022

Update! This is going into 'beta or earlier' which means it's in beta and nightly where it will stay until ready (which I'm sure might not be long, but also won't be 100 & possibly not 101 see https://bugzilla.mozilla.org/show_bug.cgi?id=1765894 ). I guess there's no way in bcd to have that kind of info as it needs a release number - unless we add a note. Happy for thoughts @hamishwillee @queengooborg

@queengooborg
Copy link
Collaborator

BCD actually does have a way to represent this! We added "preview" as a possible value for the version, which means "available in beta/nightly".

@hamishwillee
Copy link
Collaborator Author

Yes, BCD fixed in mdn/browser-compat-data#16062

@Rumyra
Copy link
Collaborator

Rumyra commented Apr 29, 2022

Star @hamishwillee thank you!

@Rumyra Rumyra moved this from Todo to Backlog in MDN Web Docs Content Team Apr 29, 2022
@Rumyra Rumyra added the on hold Waiting on something else before this can be moved forward. label Apr 29, 2022
@Rumyra Rumyra moved this from Backlog to Todo in MDN Web Docs Content Team May 16, 2022
@Rumyra
Copy link
Collaborator

Rumyra commented May 17, 2022

I'm going to add a note to the Experiemental Features page which will mean the work on this is primarily done - we can add a release note when it comes out of preview 👍

@Rumyra Rumyra moved this from Todo to In Progress in MDN Web Docs Content Team May 17, 2022
@Rumyra Rumyra moved this from In Progress to Backlog in MDN Web Docs Content Team Aug 3, 2022
@Rumyra
Copy link
Collaborator

Rumyra commented Aug 26, 2022

Still on hold so closing and will re-open once it comes around again 👍

@Rumyra Rumyra closed this as completed Aug 26, 2022
Repository owner moved this from Backlog to Done in MDN Web Docs Content Team Aug 26, 2022
@Rumyra Rumyra moved this from Done to Archive in MDN Web Docs Content Team Oct 24, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 100 labels Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs fx release archive A closed issue relating to firefox release notes for developers. on hold Waiting on something else before this can be moved forward.
Projects
Archived in project
Development

No branches or pull requests

5 participants