Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSS][Nightly only] Disable -moz-transform* and -moz-transition* properties #29785

Closed
9 of 10 tasks
Tracked by #466
Rumyra opened this issue Oct 23, 2023 · 5 comments
Closed
9 of 10 tasks
Tracked by #466
Assignees
Labels
Content:CSS Cascading Style Sheets docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Oct 23, 2023

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Related Gecko bugs

https://bugzilla.mozilla.org/show_bug.cgi?id=1855763

https://bugzil.la/390936 (CSS zoom)

Related issues and pull requests:

Other

  • Check content open issues to see if any pertain to the subject matter. If there are any that can be closed because of the work, do so. If there are any that can be fixed relatively quickly because of the knowledge from completing this issue and you have time, feel free to go ahead and fix them.
  • Check if glossary updates are required for the feature you're documenting - whether an existing term needs to be updated or a new term should be added.
  • Check if BCD update means that content pages need to have experimental markup removed or deprecated markup added (front matter tags and macros).
@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 23, 2023
@Rumyra Rumyra added Firefox 120 Content:CSS Cascading Style Sheets docs and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 23, 2023
@bsmth bsmth self-assigned this Oct 23, 2023
@bsmth
Copy link
Member

bsmth commented Oct 24, 2023

Related discussion on CSS zoom: w3c/csswg-drafts#5623

@bsmth
Copy link
Member

bsmth commented Oct 30, 2023

Note for myself to check -moz-transform* props and others under the pref:

+if (IsCSSPropertyPrefEnabled("layout.css.prefixes.transforms")) {
+  Object.assign(gCSSProperties, {
+    "-moz-transform": {
+      domProp: "MozTransform",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "transform",
+      subproperties: ["transform"],
+    },
+    "-moz-transform-origin": {
+      domProp: "MozTransformOrigin",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "transform-origin",
+      subproperties: ["transform-origin"],
+    },
+    "-moz-perspective-origin": {
+      domProp: "MozPerspectiveOrigin",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "perspective-origin",
+      subproperties: ["perspective-origin"],
+    },
+    "-moz-perspective": {
+      domProp: "MozPerspective",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "perspective",
+      subproperties: ["perspective"],
+    },
+    "-moz-backface-visibility": {
+      domProp: "MozBackfaceVisibility",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "backface-visibility",
+      subproperties: ["backface-visibility"],
+    },
+    "-moz-transform-style": {
+      domProp: "MozTransformStyle",
+      inherited: false,
+      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
+      alias_for: "transform-style",
+      subproperties: ["transform-style"],
+    },
+  });
+}

And -moz-transition*:

if (IsCSSPropertyPrefEnabled("layout.css.prefixes.transitions")) {
  Object.assign(gCSSProperties, {
    "-moz-transition": {
      domProp: "MozTransition",
      inherited: false,
      type: CSS_TYPE_TRUE_SHORTHAND,
      applies_to_marker: true,
      alias_for: "transition",
      subproperties: [
        "transition-property",
        "transition-duration",
        "transition-timing-function",
        "transition-delay",
      ],
    },
    "-moz-transition-delay": {
      domProp: "MozTransitionDelay",
      inherited: false,
      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
      applies_to_marker: true,
      alias_for: "transition-delay",
      subproperties: ["transition-delay"],
    },
    "-moz-transition-duration": {
      domProp: "MozTransitionDuration",
      inherited: false,
      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
      applies_to_marker: true,
      alias_for: "transition-duration",
      subproperties: ["transition-duration"],
    },
    "-moz-transition-property": {
      domProp: "MozTransitionProperty",
      inherited: false,
      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
      applies_to_marker: true,
      alias_for: "transition-property",
      subproperties: ["transition-property"],
    },
    "-moz-transition-timing-function": {
      domProp: "MozTransitionTimingFunction",
      inherited: false,
      type: CSS_TYPE_SHORTHAND_AND_LONGHAND,
      applies_to_marker: true,
      alias_for: "transition-timing-function",
      subproperties: ["transition-timing-function"],
    },
  });
}

@zcorpan
Copy link
Contributor

zcorpan commented Nov 6, 2023

Note that the changes for zoom, -moz-transform and -moz-transition only affect Firefox Nightly currently, not beta or stable.

cc @emilio

@bsmth
Copy link
Member

bsmth commented Nov 7, 2023

Thank you @zcorpan! I've opened a PR linked above that clarifies this (preview for convenience).

I've grouped the -moz- removals under zoom for now and put in separate sections for transform* and transition* in case only one of these change status again in future.

@bsmth bsmth changed the title [CSS] Remove -moz-transform [CSS][Nightly only] Disable -moz-transform* and -moz-transition* properties Nov 7, 2023
@bsmth
Copy link
Member

bsmth commented Nov 8, 2023

As of now, one remaining BCD pull request is awaiting review & merge, but there's nothing else outstanding on this one, so I'm closing as done.

@bsmth bsmth closed this as completed Nov 8, 2023
@Rumyra Rumyra added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 120 labels Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
Archived in project
Development

No branches or pull requests

3 participants