Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions of orientation values missing #34927

Open
jms72 opened this issue Jul 19, 2024 · 2 comments · May be fixed by #35977
Open

Descriptions of orientation values missing #34927

jms72 opened this issue Jul 19, 2024 · 2 comments · May be fixed by #35977
Assignees
Labels
Content:Manifest goal: clarity (Experimental label) Issues about unclear/confusing/inconcise content. goal: completeness (Experiment label) Issues about content missing important/relevant details.

Comments

@jms72
Copy link

jms72 commented Jul 19, 2024

MDN URL

https://developer.mozilla.org/en-US/docs/Web/Manifest/orientation

What specific section or headline is this issue about?

No response

What information was incorrect, unhelpful, or incomplete?

It's not obvious what the different values mean. E.g. portrait-primary what does it mean?

Also what is the default if none is specified.

What did you expect to see?

An explanation for each value, and which is the default.

Do you have any supporting links, references, or citations?

No response

Do you have anything more you want to share?

No response

MDN metadata

Page report details
@jms72 jms72 added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 19, 2024
@Josh-Cena
Copy link
Member

Josh-Cena commented Jul 19, 2024

There is no default value. If unspecified, it just means the app can be rotated freely. I believe if specified, rotating the device no longer changes the orientation, and it can only be changed programmatically, but it would be useful to verify that. The orientation values are defined in https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock; we should link to it.

Pinging @dipikabh since you are working on this area.

@Josh-Cena Josh-Cena removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 19, 2024
@dipikabh
Copy link
Contributor

Thanks, @Josh-Cena!
Yeah, can definitely include the clarifications in my work when I get to this page.

@dipikabh dipikabh self-assigned this Jul 22, 2024
@dipikabh dipikabh added goal: clarity (Experimental label) Issues about unclear/confusing/inconcise content. goal: completeness (Experiment label) Issues about content missing important/relevant details. labels Jul 22, 2024
@dipikabh dipikabh linked a pull request Sep 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Manifest goal: clarity (Experimental label) Issues about unclear/confusing/inconcise content. goal: completeness (Experiment label) Issues about content missing important/relevant details.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants