From 21f5afdb2f1934d85b87f7ce1d3862880306123d Mon Sep 17 00:00:00 2001 From: silverwind Date: Tue, 22 Oct 2024 02:08:03 +0200 Subject: [PATCH 1/4] Clarify that `Location.assign` and `Location.replace` also accept `URL`s --- files/en-us/web/api/location/assign/index.md | 2 +- files/en-us/web/api/location/replace/index.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/files/en-us/web/api/location/assign/index.md b/files/en-us/web/api/location/assign/index.md index ff1a70aca48bd7a..f37be7e16149410 100644 --- a/files/en-us/web/api/location/assign/index.md +++ b/files/en-us/web/api/location/assign/index.md @@ -22,7 +22,7 @@ assign(url) ### Parameters - `url` - - : A string containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. + - : A string or {{DOMXref("URL")}} object containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. ### Exceptions diff --git a/files/en-us/web/api/location/replace/index.md b/files/en-us/web/api/location/replace/index.md index a722c11ccb95ae2..93fb1e41186b149 100644 --- a/files/en-us/web/api/location/replace/index.md +++ b/files/en-us/web/api/location/replace/index.md @@ -24,7 +24,7 @@ replace(url) ### Parameters - `url` - - : A string containing the URL of the page to navigate to. + - : A string or {{DOMXref("URL")}} object containing the URL of the page to navigate to. ### Exceptions From 7aa379860f09fccb974abf31726866692d5cad56 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 23 Oct 2024 10:59:35 +0200 Subject: [PATCH 2/4] update to 'A string or any other object with a stringifier' --- files/en-us/web/api/location/assign/index.md | 2 +- files/en-us/web/api/location/replace/index.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/files/en-us/web/api/location/assign/index.md b/files/en-us/web/api/location/assign/index.md index f37be7e16149410..f767082f3a888a3 100644 --- a/files/en-us/web/api/location/assign/index.md +++ b/files/en-us/web/api/location/assign/index.md @@ -22,7 +22,7 @@ assign(url) ### Parameters - `url` - - : A string or {{DOMXref("URL")}} object containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. + - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. ### Exceptions diff --git a/files/en-us/web/api/location/replace/index.md b/files/en-us/web/api/location/replace/index.md index 93fb1e41186b149..c4426ef27008b0e 100644 --- a/files/en-us/web/api/location/replace/index.md +++ b/files/en-us/web/api/location/replace/index.md @@ -24,7 +24,7 @@ replace(url) ### Parameters - `url` - - : A string or {{DOMXref("URL")}} object containing the URL of the page to navigate to. + - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to. ### Exceptions From 297bcc4e22b973ddee5db4b79086c2b312752d17 Mon Sep 17 00:00:00 2001 From: silverwind Date: Wed, 23 Oct 2024 11:01:16 +0200 Subject: [PATCH 3/4] Update files/en-us/web/api/location/assign/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- files/en-us/web/api/location/assign/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/files/en-us/web/api/location/assign/index.md b/files/en-us/web/api/location/assign/index.md index f767082f3a888a3..95e37ce17b6a311 100644 --- a/files/en-us/web/api/location/assign/index.md +++ b/files/en-us/web/api/location/assign/index.md @@ -22,7 +22,7 @@ assign(url) ### Parameters - `url` - - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. + - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. ### Exceptions From 7b30a5a3b674695d075dd180cf300ac07477c779 Mon Sep 17 00:00:00 2001 From: Joshua Chen Date: Sat, 26 Oct 2024 14:32:03 -0400 Subject: [PATCH 4/4] Apply suggestions from code review --- files/en-us/web/api/location/assign/index.md | 2 +- files/en-us/web/api/location/replace/index.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/files/en-us/web/api/location/assign/index.md b/files/en-us/web/api/location/assign/index.md index 95e37ce17b6a311..f9aced8fe00ad3a 100644 --- a/files/en-us/web/api/location/assign/index.md +++ b/files/en-us/web/api/location/assign/index.md @@ -22,7 +22,7 @@ assign(url) ### Parameters - `url` - - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. + - : A string or any other object with a {{Glossary("stringifier")}}, such as a {{domxref("URL")}} object, containing the URL of the page to navigate to; for example, an absolute URL such as `https://developer.mozilla.org/en-US/docs/Web/API/Location/reload`, or a relative URL — such as `/Web` (just a path, for navigating to another document at the same origin) or `#specifications` (just a fragment string, for navigating to some part of the same page), and so on. ### Exceptions diff --git a/files/en-us/web/api/location/replace/index.md b/files/en-us/web/api/location/replace/index.md index c4426ef27008b0e..226ed17703851fd 100644 --- a/files/en-us/web/api/location/replace/index.md +++ b/files/en-us/web/api/location/replace/index.md @@ -24,7 +24,7 @@ replace(url) ### Parameters - `url` - - : A string or any other object with a {{Glossary("stringifier")}} containing the URL of the page to navigate to. + - : A string or any other object with a {{Glossary("stringifier")}}, such as a {{domxref("URL")}} object, containing the URL of the page to navigate to. ### Exceptions