Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Section border overlaps the examples #39

Open
mirunacurtean opened this issue Dec 11, 2020 · 5 comments
Open

[Mobile] Section border overlaps the examples #39

mirunacurtean opened this issue Dec 11, 2020 · 5 comments
Labels
effort: small Task is a small effort. enhancement Improves an existing feature. good first issue A good issue for newcomers to get started with. idle Issues and pull requests with no activity for three months. p3 We don't have visibility when this will be addressed.

Comments

@mirunacurtean
Copy link

  1. On a mobile browser open https://developer.allizom.org/en-us/docs/web/css/css_flexible_box_layout/aligning_items_in_a_flex_container#Aligning_one_item_with_align-self.
  2. Scroll through the flex examples.
  3. Notice that the section border line overlaps the example itself instead of encapsulating it.

20201211_190650

@ghost
Copy link

ghost commented Dec 11, 2020

They look like iframes. I didn't understand if there is another repository for those iframes right to the content.

Screenshot_20201211-200357.png

Perhaps an

  • iframe.scss atom should be created
  • with a 🟡 yellow
  • ... dotted
  • border
  • and padding.

@Ryuno-Ki
Copy link

My script blocker points me to https://mdn.github.io/css-examples/flexbox/alignment/align-self.html for the included iFrame.

@ghost
Copy link

ghost commented Dec 13, 2020

  • It is in Yari file system?
  • It is a Yari issue?

Screenshot_20201213-173213.png

@schalkneethling
Copy link

That border is set in the example itself:
https://mdn.github.io/css-examples/flexbox/alignment/align-items.html

So, it would need to be resolved there.

In fact you can see the problem here:

.box {
    width: 500px;
    border: 2px dotted rgb(96, 139, 168);
}

The fixed-width should be removed.

@schalkneethling schalkneethling transferred this issue from mdn/yari Jan 11, 2021
@caugner caugner added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Oct 10, 2023
@caugner
Copy link
Contributor

caugner commented Oct 10, 2023

The fixed-width should be removed.

Sounds reasonable, here's where that's located:

.box {
width: 500px;
border: 2px dotted rgb(96, 139, 168);
}

@caugner caugner added enhancement Improves an existing feature. effort: small Task is a small effort. p3 We don't have visibility when this will be addressed. good first issue A good issue for newcomers to get started with. and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Oct 10, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: small Task is a small effort. enhancement Improves an existing feature. good first issue A good issue for newcomers to get started with. idle Issues and pull requests with no activity for three months. p3 We don't have visibility when this will be addressed.
Projects
None yet
Development

No branches or pull requests

4 participants