Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width of embedded live sample preview and form controls #70

Open
schalkneethling opened this issue Apr 23, 2022 · 0 comments
Open
Assignees
Labels
bug Indicates an unexpected problem or unintended behavior. idle Issues and pull requests with no activity for three months.

Comments

@schalkneethling
Copy link

schalkneethling commented Apr 23, 2022

Hey @mdn/mdn-community-engagement! For the current embed live sample the width is set to 90% with a max-width of 700px. This might have worked with the previous MDN Web Docs layout, but is causing problems with some of the examples leading to confusion.

For example, even with the correct code, the following example on .. displays incorrectly:
https://developer.mozilla.org/en-US/docs/Learn/CSS/CSS_layout/Multicol_skills#multicol_two

Screenshot of embedded live sample showing a two column layout when the learner will expect to see a three column layout

If we update styles.css, set the width to 100% and remove the max-width, the output is as expected.

Screenshot of embedded live sample showing the correct three column layout

With the above change, we would also need to set the form elements to 100%.

@schalkneethling schalkneethling added the bug Indicates an unexpected problem or unintended behavior. label Apr 23, 2022
@schalkneethling schalkneethling self-assigned this Apr 23, 2022
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior. idle Issues and pull requests with no activity for three months.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant