-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(macros/Firefox_for_developers): remove the parameter and add zh-CN translation #10034
Conversation
/cc @jasonren0403. Please check the zh-CN translation in this PR. I've posted this in the Telegram group before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for zh-CN translation 👍
ping @bsmth for another eye on this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks way more readable to me, thank you! Leaving it for other expert eyes to take a look before merging 👀
edit 30th Nov: I'll ask engineering about this one today, thanks for the patience 🙏🏻
(Quick update) - The engineering team know about this one and will get around to it soon, hopefully. 🙏🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long delay and thanks a for cleaning this up.
Thanks for the review @fiji-flo. Is there any thing blocking this? |
@yin1999 just didn't press the button |
FWIW Why do we show the "older versions" rather than "all versions". On release of a new version there is no difference. Later on when version "x" is old, I am unlikely to care about version x-1, but I might well care about the current version. |
Summary
slug
).Solution
Gather the version info from the
slug
.Screenshots
Note, the lists in
/en-US/docs/Mozilla/Firefox/Releases/2
are not consistent.How did you test this change?
yarn dev
and check rendered pagerg -il "Firefox_for_developers"
to check the occurrences of this macro in content and translated-content.