Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/Firefox_for_developers): remove the parameter and add zh-CN translation #10034

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Nov 15, 2023

Summary

  1. Added zh-CN translation for this macro.
  2. Removed the usage of "version" param, as this is not really necessary (we can infer the version information from the slug).

Solution

Gather the version info from the slug.


Screenshots

URL Before After
/en-US/docs/Mozilla/Firefox/Releases/2 image image
/en-US/docs/Mozilla/Firefox/Releases/3.6 image image
/en-US/docs/Mozilla/Firefox/Releases/4 image image
/en-US/docs/Mozilla/Firefox/Releases/24 image image
/en-US/docs/Mozilla/Firefox/Releases/121 image image

Note, the lists in /en-US/docs/Mozilla/Firefox/Releases/2 are not consistent.


How did you test this change?

  1. Run yarn dev and check rendered page
  2. Run rg -il "Firefox_for_developers" to check the occurrences of this macro in content and translated-content.

@yin1999 yin1999 requested a review from a team as a code owner November 15, 2023 12:48
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 15, 2023
@yin1999
Copy link
Member Author

yin1999 commented Nov 15, 2023

/cc @jasonren0403. Please check the zh-CN translation in this PR. I've posted this in the Telegram group before.

Copy link
Contributor

@jasonren0403 jasonren0403 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for zh-CN translation 👍

@yin1999
Copy link
Member Author

yin1999 commented Nov 15, 2023

ping @bsmth for another eye on this PR :)

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks way more readable to me, thank you! Leaving it for other expert eyes to take a look before merging 👀

edit 30th Nov: I'll ask engineering about this one today, thanks for the patience 🙏🏻

@yin1999 yin1999 changed the title chore(macros/Firefox_for_developers): refactor and add zh-CN translation refactor(macros/Firefox_for_developers): remove the parameter and add zh-CN translation Nov 18, 2023
@bsmth
Copy link
Member

bsmth commented Dec 11, 2023

(Quick update) - The engineering team know about this one and will get around to it soon, hopefully. 🙏🏻

@github-actions github-actions bot added the idle label Jan 24, 2024
@caugner caugner changed the title refactor(macros/Firefox_for_developers): remove the parameter and add zh-CN translation chore(macros/Firefox_for_developers): remove the parameter and add zh-CN translation Jan 26, 2024
@github-actions github-actions bot removed the idle label Jan 27, 2024
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay and thanks a for cleaning this up.

@yin1999
Copy link
Member Author

yin1999 commented Feb 23, 2024

Thanks for the review @fiji-flo. Is there any thing blocking this?

@fiji-flo
Copy link
Contributor

@yin1999 just didn't press the button

@fiji-flo fiji-flo merged commit c8c3908 into mdn:main Feb 23, 2024
10 checks passed
@yin1999 yin1999 deleted the ffd branch February 23, 2024 22:31
@hamishwillee
Copy link
Contributor

hamishwillee commented Feb 29, 2024

FWIW Why do we show the "older versions" rather than "all versions". On release of a new version there is no difference. Later on when version "x" is old, I am unlikely to care about version x-1, but I might well care about the current version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants