Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(telemetry): remove and migrate GA measurements to Glean #10527

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 15, 2024

Summary

Part of MP-871.

Problem

We're migrating from GA3 to GA4 and there are some custom measurements that we can migrate to Glean instead of moving them over to GA4.

Solution

  1. Remove an unnecessary measurement regarding the X-Cache response header, which no longer applies to our new setup in GCP.
  2. Migrate the measurement for the a11y navigation from GA to Glean.
  3. Add a Glean measurement for the client-side navigation GA measurement.
  4. Migrate the measurement for the locale-menu from GA to Glean.

Screenshots

(No visual changes.)


How did you test this change?

@caugner caugner requested a review from a team as a code owner February 15, 2024 12:37
We no longer set the X-Cache header since we moved from AWS to GCP.
This measurement will allow us to investigate whether these
really are client-side navigations, or false-positives.
Note that we no longer need the target URL, because all locales
now use the same slugs, and the source URL is already part of
what we set on the Glean events by default.
@caugner caugner force-pushed the remove-and-migrate-ga-measurements branch from c2cb754 to d3f6f9f Compare February 15, 2024 12:57
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@fiji-flo fiji-flo merged commit fc4da56 into main Mar 13, 2024
15 checks passed
@fiji-flo fiji-flo deleted the remove-and-migrate-ga-measurements branch March 13, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants