enhance(build/spas): allow yarn dev without internet if DEV_MODE is enabled #10533
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-899)
Problem
When working on a train or a plane without internet, you cannot run
yarn dev
, because it fails when building the SPA.Solution
Convert the errors to warnings if
DEV_MODE
is enabled (via settingREACT_APP_DEV_MODE=true
in the.env
).Note: Technically,
yarn tool popularities
is also affected, but the command defaults to not downloading the popularities again if they already exist (unless--refresh
is provided), so this PR doesn't cover that case (just don't delete yourpopularities.json
when you're on a plane 🙂).Screenshots
Before
After
How did you test this change?
Ran
yarn tool spas
with wifi disabled (see above).