fix(bcd): re-surface "see bug xxxxx" notes #10549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10522
Relates to web-platform-dx/web-features#591
cc @queengooborg, @foolip
Problem
bcd migrated to using the
impl_url
field over thenotes
field in most cases: mdn/browser-compat-data#20608Solution
this commit attempts to bring back the same functionality as before
Screenshots
Before mdn/browser-compat-data#20608
Before
After
How did you test this change?
Set
REACT_APP_BCD_BASE_URL=""
in.env
in order to use local bcd data, rather than stage data.In
yari/node_modules/@mdn/browser-compat-data/data.json
, replacedwith
Visited http://localhost:3000/en-US/docs/Web/API/HTMLElement/accessKeyLabel#browser_compatibility to test that the display of the
notes
with Chrome was the same as the display ofimpl_url
with Edge, and that the malformed url with Chrome for Android rendered without error.Also installed the version of BCD prior to mdn/browser-compat-data#20608 with
yarn add @mdn/browser-compat-data@v5.3.13
.