fix(types): pass types through memoize properly

[LeoMcA]

Summary

Problem

While reviewing #10433 it annoyed me that memoize wasn't passing types through properly, and we were losing types in most of build/curriculum.ts because of this.

Solution

Pass through the types of the wrapped function in memoize, fix the things this breaks. (I suggest reviewing with ignore whitespace because one function gets majorly indented from these fixes).

---

How did you test this change?

yarn check:tsc

[caugner]

Very nice, just skimmed over, and left some comments.

[caugner]

This doesn't look right. Why would kumascript.render() return a BlogPostDoc?

[LeoMcA]

It doesn't, this is the last argument, the return type is the line below (the Promise)

[fiji-flo]

That should stay called doc it just replaces the Document.findByURL. And the type is tricky. Probably Doc as BlogPostDoc should just extend Doc but that is utterly broken right now.

[caugner]

I don't think Doc applies here, as it has many more fields/requirements compared to BlogPostDoc.

BlogPostDoc:

yari/build/blog.ts

Lines 347 to 355 in 006eb85

	interface BlogPostDoc {
	url: string;
	rawBody: string;
	metadata: BlogPostMetadata & { locale: string };
	isMarkdown: boolean;
	fileInfo: {
	path: string;
	};
	}

DocMetadata/Doc:

yari/libs/types/document.ts

Lines 128 to 159 in 006eb85

	export interface DocMetadata {
	title: string;
	short_title: string;
	locale: string;
	native: string;
	pageTitle: string;
	mdn_url: string;
	related_content: any[];
	modified: string;
	flaws: Flaws;
	other_translations?: Translation[];
	parents?: DocParent[];
	source: Source;
	contributors: string[];
	isTranslated: boolean;
	isActive: boolean;
	hasMathML?: boolean;
	isMarkdown: boolean;
	summary: string;
	popularity?: number; // Used for search.
	noIndexing?: boolean;
	browserCompat?: string[];
	baseline?: SupportStatus;
	hash?: string;
	}
	export interface Doc extends DocMetadata {
	sidebarHTML: string;
	sidebarMacro?: string;
	toc: Toc[];
	body: Section[];
	}

[caugner]

Btw should BlogPostDoc be moved into libs/types?

[yin1999]

We can replace the type declaration here, as there was a duplicated one in libs/types/document.ts

[caugner]

Good catch, fixed in c00822d.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[caugner]

@LeoMcA Please have a look at the changes I pushed, but LGTM.