enhance(ai-help): improve stopped state #10580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
plus
|
This pull request has merge conflicts that must be resolved before it can be merged. |
github-actions
bot
removed
the
merge conflicts 🚧
LeoMcA
approved these changes
Feb 28, 2024
| @@ -159,6 +159,7 @@ $mdn-theme-light-text-active: #{$mdn-color-neutral-50}; | |||
| $mdn-theme-light-text-inactive: #{$mdn-color-neutral-40}a6; | |||
| $mdn-theme-light-text-link: $mdn-color-light-theme-blue-60; | |||
| $mdn-theme-light-text-invert: $mdn-color-white; | |||
| $mdn-theme-light-text-muted: #6f6f6f; | |||
There was a problem hiding this comment.
Nit: I wouldn't add further sass variables if we don't need them anywhere, just define the css variable directly
There was a problem hiding this comment.
I'll keep it, as I had wanted to use this color in other circumstances before (being familiar with Bootstrap).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-867)
Problem
When the user presses "Stop answering", the only indication are three dots ("...") at the end of the answer, and the icon before "Answer:" is still blinking.
Solution
Add a separate line that says "Stopped answering", change "Answer:" to "Answer (stopped):" and make sure the icon doesn't blink.
Screenshots
Before
After
How did you test this change?
Asked the first example question and pressed "Stop answering" as soon as the answer started to appear.