Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blog): remove playground queue #10666

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat(blog): remove playground queue #10666

merged 1 commit into from
Mar 7, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented Mar 7, 2024

Summary

Stop showing a queue and play button on non-live-sample code snippets.

Note: for now we keep the now unused hook around.


Screenshots

Before

image

After

image


How did you test this change?

locally using http://localhost:3000/en-US/blog/leveraging-bun-on-vultr-a-superior-node-js-alternative/

Stop showing a queue and play button on non-live-sample
code snippets.

Note: for now we keep the now unused hook around.
@fiji-flo fiji-flo requested a review from a team as a code owner March 7, 2024 16:43
@github-actions github-actions bot added the blog label Mar 7, 2024
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove the unused hook as well, as I don't think we're gonna use it anytime soon, but otherwise LGTM.

@fiji-flo
Copy link
Contributor Author

fiji-flo commented Mar 7, 2024

Moved cleanup to MP-928

@fiji-flo fiji-flo merged commit b432d38 into main Mar 7, 2024
14 checks passed
@fiji-flo fiji-flo deleted the remove-blog-queue branch March 7, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants