Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation for 5 locations #11507

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Jul 20, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

  • There is no Japanese translation yet

English pages

Japanese pages

before after
スクリーンショット 2024-07-20 13 58 23 スクリーンショット 2024-07-20 14 17 10
スクリーンショット 2024-07-20 14 20 23 スクリーンショット 2024-07-20 14 10 23

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@mdn/core-dev

Please merge once mdn-yari-ja is approved.

Before

  • There is no Japanese translation yet

After

  • tranlate japanese for LearnSidebar.ejs

@gurezo gurezo requested a review from a team as a code owner July 20, 2024 05:26
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Jul 20, 2024
'Web_forms_core' : 'ウェブフォームの構成要素',
'Web_forms_advanced': '高度なウェブフォームテクニック',
'Accessibility_—_Make_the_web_usable_by_everyone' : 'アクセシビリティ誰もウェブを利用できるようにする',
'Accessibility_guides' : 'アクセシビリティガイド',
'Accessibility_assessment' : 'Accessibility assessment',
'Performance' : 'パフォーマンス — ウェブサイトを高速かつ応答性の高いものにする',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ja: Accessibility_assessment に該当する箇所がなかったので、翻訳しませんでした。
  • en: There was no corresponding section in the Accessibility_assessment, so we did not translate it.

Copy link
Contributor

@hmatrjp hmatrjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

訳された5つはいいと思います。
Accessibility_assessment は、定義はされているけれど、使われていないということですね。

@gurezo
Copy link
Contributor Author

gurezo commented Jul 20, 2024

@hmatrjp

訳された5つはいいと思います。 Accessibility_assessment は、定義はされているけれど、使われていないということですね。

はい。その通りです。

@hmatrjp
Copy link
Contributor

hmatrjp commented Jul 20, 2024

@mdn/core-dev , review from japan side is finished. please go ahead.

@caugner caugner merged commit b342cae into mdn:main Jul 24, 2024
9 checks passed
@gurezo gurezo deleted the issues/isuue/784 branch September 21, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants