Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation MathML section #11680

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Aug 24, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

  • There is no Japanese translation yet

English pages

Japanese pages

before after
スクリーンショット 2024-08-24 13 22 01 スクリーンショット 2024-08-24 13 34 08

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@mdn/core-dev

Please merge once mdn-yari-ja is approved.

Before

  • There is no Japanese translation yet

After

  • tranlate japanese for LearnSidebar.ejs

@gurezo gurezo requested a review from a team as a code owner August 24, 2024 04:37
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Aug 24, 2024
Copy link
Contributor

@hmatrjp hmatrjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@caugner caugner merged commit 606e5cb into mdn:main Sep 6, 2024
9 checks passed
@gurezo gurezo deleted the issues/isuue/785 branch September 21, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants