Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros): delete DOMAttributeMethods + unimplemented_inline macros #11790

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

yin1999
Copy link
Member

@yin1999 yin1999 commented Sep 11, 2024

Summary

delete DOMAttributeMethods + unimplemented_inline macros

Problem

Those two macros have been deprecated and removed from translated-content. We can now safely remove them from yari.

Run rg to test the occurrence of them:

rg -il "unimplemented_inline"

rg -il "DOMAttributeMethods"

image

@yin1999 yin1999 requested a review from a team as a code owner September 11, 2024 00:57
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 11, 2024
@caugner caugner merged commit e0b7616 into mdn:main Sep 11, 2024
9 checks passed
@caugner
Copy link
Contributor

caugner commented Sep 11, 2024

Awesome, thank you @yin1999! 🎉

@yin1999 yin1999 deleted the delete-macros branch September 11, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants