Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(placement): use variable for horizontal banner #11795

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Sep 11, 2024

Summary

(MP-1500)

Problem

The horizontal banner on Playground was using a hard-coded color (#111) for the gradient.

Solution

Use the --place-new-side-background variable instead.


Screenshots

Before

image

After

image

How did you test this change?

Ran yarn dev locally with REACT_APP_KUMA_HOST=developer.allizom.org, then tested on http://localhost:3000/en-US/play.

This is also deployed to stage, as of 2024-09-11.

@caugner caugner requested a review from a team as a code owner September 11, 2024 16:44
Copy link
Contributor Author

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-approval, as this is an urgent fix, and the change replicates behavior of the side banner.

@caugner caugner merged commit d880aaf into main Sep 11, 2024
14 checks passed
@caugner caugner deleted the MP-1500-use-variable-for-horizontal-ad-gradient branch September 11, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant