Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translations for HTML and CSS #11840

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Sep 21, 2024

Summary

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

Problem

  • There is no Japanese translation yet

English pages

Japanese pages

section before after
HTML スクリーンショット 2024-09-21 13 49 01 スクリーンショット 2024-09-21 14 20 40
CSS スクリーンショット 2024-09-21 13 55 26 スクリーンショット 2024-09-21 14 09 52

Solution

translate japanese for LearnSidebar.ejs

NOTICE

@mdn/core-dev

Please merge once mdn-yari-ja is approved.

Before

  • There is no Japanese translation yet

After

  • tranlate japanese for LearnSidebar.ejs

@gurezo gurezo requested a review from a team as a code owner September 21, 2024 05:31
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 21, 2024
@gurezo
Copy link
Contributor Author

gurezo commented Sep 21, 2024

@hmatrjp @potappo , mdn-yari-ja

please review for this pull request

@mdn/core-dev

one question.
this PR was failed Compare bundle size / Build head (pull_request)

This action(Compare bundle size / Build head) was not included in the previous PR(#11680).

スクリーンショット 2024-09-21 14 48 02

other actions are passed.
Please let me know how to fix this error.

I made two PRs(#11839, #11840) with the same results.

Copy link
Contributor

@potappo potappo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gurezo , translation looks good.

Copy link

@IreneSAvila IreneSAvila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gurezo
Copy link
Contributor Author

gurezo commented Oct 5, 2024

@IreneSAvila
i had rebased main to my branch, and force push now.
if it will be passed CI, Please review and merge.

@gurezo
Copy link
Contributor Author

gurezo commented Oct 18, 2024

Hi @mdn/core-dev
this pr already had arroved, when to merge?

@caugner caugner changed the title chore(macros/LearnSidebar): add translate HTML, CSS section chore(macros/LearnSidebar): add Japanese translations for HTML and CSS Oct 18, 2024
@caugner caugner merged commit 85b9436 into mdn:main Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants