Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature removals in BCD use a misleading version range #3971

Closed
foolip opened this issue Jun 4, 2021 · 5 comments
Closed

Feature removals in BCD use a misleading version range #3971

foolip opened this issue Jun 4, 2021 · 5 comments
Labels
browser-compat issues related to the browser compatibility data tables (BCD) 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.

Comments

@foolip
Copy link
Contributor

foolip commented Jun 4, 2021

I was sure I'd already filed an issue for this, but maybe it was for the old MDN site...

Take a look at this table:
https://developer.mozilla.org/en-US/docs/Web/API/FetchEvent/replacesClientId#browser_compatibility

The data for Edge being rendered here is:

"edge": {
  "version_added": "18",
  "version_removed": "79"
},

This is rendered as "18 — 79" on a red background. I think the natural interpretation of this that the feature was in versions 18-79, but the correct interpretation is that it was in Edge 18 only.

I think the logic here should be:

  • The displayed end range is the version before version_removed in BCD.
  • If that is the same as the start range, show just a single number on red, "18" in this case.

cc @Elchi3 @ddbeck

@foolip
Copy link
Contributor Author

foolip commented Jun 4, 2021

While in the area, I'll also the the chance to complain about the use of the wide em dashes (—) here. The narrow en dash (–) is more commonly used to represent ranges.

Edit: #3972

@teoli2003
Copy link
Contributor

@foolip Is 79 a typo, and you meant 19 ?

@foolip
Copy link
Contributor Author

foolip commented Jun 4, 2021

@teoli2003 no, this is a case of something that was in Edge 18 and then removed in Edge 79, which is the case where the problem is the most obvious.

@teoli2003
Copy link
Contributor

Oh yes, my bad, I understand now. Makes sense!

@caugner
Copy link
Contributor

caugner commented Nov 15, 2022

Duplicate of #6667.

@caugner caugner closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2022
@caugner caugner added the browser-compat issues related to the browser compatibility data tables (BCD) label Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-compat issues related to the browser compatibility data tables (BCD) 🐌 idle Issues and PRs without recent activity. Flagged for maintainer follow-up.
Projects
Development

No branches or pull requests

4 participants