fix: Wrap SVG Mandala to reduce CPU usage #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiji-flo
approved these changes
May 9, 2023
|
@fiji-flo Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8621
Summary
This wraps the SVG Mandala element in a
<div>and applies the animation there instead of directly on the SVG.Problem
Some changes to CSS properties cause the browser to re-raster the whole SVG. If you go to the MDN as it is today you can see the effect this has on CPU usage. See screenshots below.
Solution
Browsers can transform SVG without having to re-raster when the transform happens outside the SVG.
Screenshots
There are no visual changes to the Mandala on the homepage or the Contributor Spotlight section.
Before
After