Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): baseline indicator #8772

Merged
merged 1 commit into from
May 10, 2023
Merged

feat(docs): baseline indicator #8772

merged 1 commit into from
May 10, 2023

Conversation

LeoMcA
Copy link
Member

@LeoMcA LeoMcA commented May 4, 2023

See https://mozilla-hub.atlassian.net/browse/MP-325 and https://mozilla-hub.atlassian.net/browse/MP-382.

Ignore the first 4 xyz-build related commits please.

@caugner it would be great to get a review on this draft, even though the data/copy/(mobile) designs aren't entirely finalised, to remove some pressure from next week.

@LeoMcA LeoMcA requested a review from caugner May 4, 2023 16:50
@github-actions github-actions bot added dependencies Pull requests that update a dependency file github-actions labels May 4, 2023
@LeoMcA LeoMcA temporarily deployed to xyz May 4, 2023 17:16 — with GitHub Actions Inactive
@LeoMcA LeoMcA temporarily deployed to xyz May 4, 2023 17:58 — with GitHub Actions Inactive
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nits (⚠️ > 🟠 > 🟡 > 🟢 ).

build/index.ts Outdated Show resolved Hide resolved
build/index.ts Outdated Show resolved Hide resolved
client/src/document/baseline-indicator.scss Outdated Show resolved Hide resolved
client/src/document/baseline-indicator.scss Outdated Show resolved Hide resolved
client/src/document/index.tsx Outdated Show resolved Hide resolved
client/src/document/baseline-indicator.scss Outdated Show resolved Hide resolved
client/src/document/baseline-indicator.scss Show resolved Hide resolved
client/src/ui/base/_themes.scss Outdated Show resolved Hide resolved
libs/types/document.ts Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@caugner caugner changed the title feature(docs): baseline indicator feat(docs): baseline indicator May 4, 2023
@LeoMcA LeoMcA temporarily deployed to xyz May 5, 2023 16:48 — with GitHub Actions Inactive
@LeoMcA LeoMcA requested review from fiji-flo and caugner May 5, 2023 17:02
@LeoMcA LeoMcA temporarily deployed to xyz May 5, 2023 17:32 — with GitHub Actions Inactive
@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 9, 2023
@LeoMcA LeoMcA temporarily deployed to xyz May 9, 2023 15:39 — with GitHub Actions Inactive
@LeoMcA LeoMcA temporarily deployed to xyz May 9, 2023 16:34 — with GitHub Actions Inactive
Copy link
Contributor

@caugner caugner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 , tested locally on these pages:

PS: I agree with Miruna that the case where a feature is supported in all browsers, but not yet in two major versions, is not yet ideal.

@github-actions github-actions bot added the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

</p>
<ul>
<li>
<a href="/en-US/blog/baseline-unified-view-stable-web-features/">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When mdn/content#26676 merges there will be a less ephemeral page to link to

@github-actions github-actions bot removed the merge conflicts 🚧 Please rebase onto or merge the latest main. label May 10, 2023
@LeoMcA LeoMcA temporarily deployed to xyz May 10, 2023 12:47 — with GitHub Actions Inactive
@LeoMcA LeoMcA temporarily deployed to xyz May 10, 2023 13:29 — with GitHub Actions Inactive
@LeoMcA LeoMcA marked this pull request as ready for review May 10, 2023 15:06
@LeoMcA LeoMcA merged commit 35786d8 into main May 10, 2023
@LeoMcA LeoMcA deleted the baseline-prototype branch May 10, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants