fix(lint-staged): use negative pattern correctly #8842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Negative patterns must start with the `!`, not contain it. This is why YAML files were not formatted since 6184aff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(MP-410)
Problem
YAML files were not automatically formatted with prettier as part of
lint-staged, because the negative pattern for other files (introduced in 6184aff) is not correct. (Negative patterns must start with the!, not contain it.)Solution
Fix the negative pattern.
Screenshots
Before
After
How did you test this change?
Tested by updating a YAML file to use single quotes (
'), staging the changes, and runningyarn lint-stagedthereafter.