Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CSS): last elements inside blockquotes do not need bottom margin #8855

Merged
merged 1 commit into from
May 15, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 15, 2023

Summary

This PR adds a CSS rule to strip the bottom margin from last elements inside blockquotes.

See:

Problem

The styles for blockquotes looks a little wobbly and difficult to read.

Solution

Add a rule like the following:

.main-page-content .section-content blockquote > :last-child {
  margin-bottom: 0;
}

Screenshots

Before

image

image

After

image


How did you test this change?

Running on localhost.

@bsmth bsmth added the layout Issues related to alignment, positioning and spacing/margin/padding label May 15, 2023
Copy link
Member

@LeoMcA LeoMcA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@LeoMcA LeoMcA merged commit 80094ea into mdn:main May 15, 2023
@bsmth bsmth deleted the fix-blockquote-margin branch May 15, 2023 13:17
@bsmth
Copy link
Member Author

bsmth commented May 15, 2023

Thank you! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
layout Issues related to alignment, positioning and spacing/margin/padding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants