-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump (dev)Dependencies, fix: consider first jsx node as open tag - close #272 #273
Conversation
the parsed remark-mdx jsx nodes are not precise, but it will be resolved in v2
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 424 436 +12
Branches 79 82 +3
=========================================
+ Hits 424 436 +12
Continue to review full report at Codecov.
|
@JounQin What’s the reason for the ping? A code review or something else? If the first: I’ve never really looked into the code of this project much and this PR also seems to contain several code-style changes, so this looks okay but I’m not really sure what part I should focus on? |
improve fixtures test case
@wooorm I've highlighted the important changes at #273 (comment) . |
I’m generally fine with this, because I trust your opinion more that mine on this project! I’d guess the |
Did you mean the following And See 5813078 |
@mdx-js/releasers Please help to release a new version. |
@wooorm Any time to cut a release? |
Released! |
fix #272
the parsed remark-mdx jsx nodes are not precise, but it will be resolved in v2