Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean up rebass #295

Merged
merged 3 commits into from
Mar 20, 2021
Merged

fix: clean up rebass #295

merged 3 commits into from
Mar 20, 2021

Conversation

chenxsan
Copy link
Contributor

Closes GH-294.

@codecov-io
Copy link

codecov-io commented Mar 20, 2021

Codecov Report

Merging #295 (8499ec3) into master (260a07e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #295   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          517       514    -3     
  Branches       101       101           
=========================================
- Hits           517       514    -3     
Impacted Files Coverage Δ
...ackages/eslint-plugin-mdx/src/configs/overrides.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260a07e...8499ec3. Read the comment docs.

@JounQin
Copy link
Member

JounQin commented Mar 20, 2021

We don’t put dev in workspace packages, move it to root package.json instead.

@JounQin
Copy link
Member

JounQin commented Mar 20, 2021

I thought rebass been bundled with mdx itself because it is mentioned in the playground, if it’s not, then rebass related codes should all be remove in this repo.

—-

rebass is actaully not bundled with mdx but it’s global available on playground only.

@chenxsan
Copy link
Contributor Author

Moving to the root package.json will cause eslint to show errors:

image

Does it mean I have to update eslint configuration as well?

@JounQin
Copy link
Member

JounQin commented Mar 20, 2021

As described at #295 (comment)

You can remove all codes related to rebass, and remove rebass as dep, not even dev.

https://github.com/mdx-js/eslint-mdx/blob/master/packages/eslint-plugin-mdx/src/configs/overrides.ts

@JounQin
Copy link
Member

JounQin commented Mar 20, 2021

@types/rebass should be removed too.

https://github.com/mdx-js/eslint-mdx/blob/master/package.json#L33

@chenxsan chenxsan changed the title fix: move rebass to devDependencies fix: clean up rebass Mar 20, 2021
@JounQin
Copy link
Member

JounQin commented Mar 20, 2021

Thanks for cleaning up!

@JounQin JounQin merged commit 4974093 into mdx-js:master Mar 20, 2021
@JounQin JounQin added the 🏡 area/internal This affects the hidden internals label Mar 20, 2021
@chenxsan chenxsan deleted the move-rebass branch March 20, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals
Development

Successfully merging this pull request may close these issues.

rebass is installed
3 participants