Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to async API on processSync error via synckit #307

Merged
merged 4 commits into from
Apr 29, 2021

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Apr 26, 2021

@JounQin JounQin added 🦋 type/enhancement This is great to have internal :house: Internal 🏡 area/internal This affects the hidden internals labels Apr 26, 2021
@JounQin JounQin self-assigned this Apr 26, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #307 (2d532f1) into master (a893aa7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #307   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          451       468   +17     
  Branches        90        96    +6     
=========================================
+ Hits           451       468   +17     
Impacted Files Coverage Δ
packages/eslint-plugin-mdx/src/rules/helpers.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/rules/remark.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a893aa7...2d532f1. Read the comment docs.

@JounQin
Copy link
Member Author

JounQin commented Apr 27, 2021

image

Thanks to @codesandbox, I found a bug locally, and it's just working now!

@JounQin JounQin merged commit 94a08af into master Apr 29, 2021
@JounQin JounQin deleted the feat/synckit branch April 29, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 area/internal This affects the hidden internals internal :house: Internal 🦋 type/enhancement This is great to have
Development

Successfully merging this pull request may close these issues.

Support async processing
2 participants