Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: same markdown processor cached for .md and .mdx #401

Merged
merged 1 commit into from
Jun 12, 2022

Conversation

gyanta
Copy link
Contributor

@gyanta gyanta commented Jun 12, 2022

Closes #400

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member

JounQin commented Jun 12, 2022

@gyanta Sorry, please run prettier or eslint --fix locally or on GitPod.

@gyanta
Copy link
Contributor Author

gyanta commented Jun 12, 2022

Oops, missed that - thanks @JounQin!

@JounQin JounQin self-assigned this Jun 12, 2022
@JounQin JounQin added the 👶 semver/patch This is a backwards-compatible fix label Jun 12, 2022
@JounQin
Copy link
Member

JounQin commented Jun 12, 2022

Thanks for your contribution! @gyanta

@gyanta
Copy link
Contributor Author

gyanta commented Jun 12, 2022

My pleasure, thanks for all your work on this!

@JounQin JounQin merged commit c1b4671 into mdx-js:master Jun 12, 2022
@JounQin
Copy link
Member

JounQin commented Jun 12, 2022

@wooorm I believe we can publish a stable v2 version now.

@JounQin
Copy link
Member

JounQin commented Jun 16, 2022

ping @wooorm

@wooorm
Copy link
Member

wooorm commented Jun 18, 2022

I’ll try to get to it tomorrow. Please ping me if I don’t!

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

Are you sure everything is ready for a stable? 2.0.0? Exciting!
I am guessing that yarn release will make a patch? How do you want me to release it?

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

Are you sure everything is ready for a stable? 2.0.0? Exciting!

From my personal view, yes it's! I've been using the beta version for a long time.

I am guessing that yarn release will make a patch? How do you want me to release it?

I think yarn release will just do the right thing.

Or you can try yarn release --dry-run at least.

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

I think it’s making a next release right now 🤔

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

lerna publish major --conventional-commits --create-release github --yes

^-- this probably?

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

(Lerna seems bad for version management for this point. 😅)

I've migrated to https://github.com/changesets/changesets for most of my projects.

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

lerna publish major --conventional-commits --create-release github --yes

^-- this probably?

Maybe, hope it will work correctly. 😅

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

nope :'(

lerna notice cli v4.0.0
lerna info current version 2.0.0-next.6
lerna notice Current HEAD is already released, skipping change detection.
lerna success No changed packages to publish 

Is there like a force flag?

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

@wooorm

#396 (comment)

You'd better to do dry-run first?

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

@wooorm

Or force push back the latest commit first to generate a correct changelog?

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

boom, worked!

@wooorm
Copy link
Member

wooorm commented Jun 19, 2022

Can you manage the release notes?

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

Can you manage the release notes?

Yes, just going to do this and change the changelog manually.

@JounQin
Copy link
Member

JounQin commented Jun 19, 2022

Done! https://github.com/mdx-js/eslint-mdx/releases/tag/v2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👶 semver/patch This is a backwards-compatible fix
Development

Successfully merging this pull request may close these issues.

mdx files are linted as markdown if the first processed file is not mdx
3 participants